Re: [PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2
On Sun, Jan 15, 2017 at 09:40:24AM -0800, Florian Fainelli wrote: > On 01/15/2017 03:08 AM, Greg KH wrote: > > On Sat, Jan 14, 2017 at 01:47:03PM -0800, Florian Fainelli wrote: > >> Hi all, > >> > >> This is not exactly new, and was sent before, although back then, I did not > >> have an user of the pre-declared MDIO board information, but now we do. > >> Note > >> that I have additional changes queued up to have b53 register platform > >> data for > >> MIPS bcm47xx and bcm63xx. > >> > >> Yes I know that we should have the Orion platforms eventually be converted > >> to > >> Device Tree, but until that happens, I don't want any remaining users of > >> the > >> old "dsa" platform device (hence the previous DTS submissions for > >> ARM/mvebu) > >> and, there will be platforms out there that most likely won't never see DT > >> coming their way (BCM47xx is almost 100% sure, BCM63xx maybe not in a > >> distant > >> future). > >> > >> We would probably want the whole series to be merged via David Miller's > >> tree > >> to simplify things. > >> > >> Greg, can you Ack/Nack patch 5 since it touched the core LDD? > > > > I've NAKed them for now, you need to describe what you are trying to do > > here, as it doesn't make any sense to me at the moment. > > For one, this is moving *existing* code from net/dsa/dsa.c part into the > device core for device_find_class() and part into the network device > core for dev_to_net_device(). Patch 8 is where this actually gets used. > See my individual replies for more details. > > Even though the existing code is there in net/dsa/dsa.c, at this point, > and for the sake of getting these patches merged via David, I can > probably just keep it where it is (like what patch series v1 did) and > just namespace it with dsa_. Later on, if this is deemed valuable to > other parts of the kernel, I can try to relocate it to the device core, > does that sound acceptable? Nope! I really want to try to understand what you all are doing with the device tree that you feel that blindly walking it actually comes up with a valid result. See my other email about wanting to see a tree, we can take it from that thread to try to consolidate all of these different ones. And sorry, I know you are just trying to move code around, but this isn't the first time this has come up, and I think it needs to be resolved properly. thanks, greg k-h
Re: [PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2
On 01/15/2017 03:08 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:03PM -0800, Florian Fainelli wrote: >> Hi all, >> >> This is not exactly new, and was sent before, although back then, I did not >> have an user of the pre-declared MDIO board information, but now we do. Note >> that I have additional changes queued up to have b53 register platform data >> for >> MIPS bcm47xx and bcm63xx. >> >> Yes I know that we should have the Orion platforms eventually be converted to >> Device Tree, but until that happens, I don't want any remaining users of the >> old "dsa" platform device (hence the previous DTS submissions for ARM/mvebu) >> and, there will be platforms out there that most likely won't never see DT >> coming their way (BCM47xx is almost 100% sure, BCM63xx maybe not in a distant >> future). >> >> We would probably want the whole series to be merged via David Miller's tree >> to simplify things. >> >> Greg, can you Ack/Nack patch 5 since it touched the core LDD? > > I've NAKed them for now, you need to describe what you are trying to do > here, as it doesn't make any sense to me at the moment. For one, this is moving *existing* code from net/dsa/dsa.c part into the device core for device_find_class() and part into the network device core for dev_to_net_device(). Patch 8 is where this actually gets used. See my individual replies for more details. Even though the existing code is there in net/dsa/dsa.c, at this point, and for the sake of getting these patches merged via David, I can probably just keep it where it is (like what patch series v1 did) and just namespace it with dsa_. Later on, if this is deemed valuable to other parts of the kernel, I can try to relocate it to the device core, does that sound acceptable? -- Florian
Re: [PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2
On Sat, Jan 14, 2017 at 01:47:03PM -0800, Florian Fainelli wrote: > Hi all, > > This is not exactly new, and was sent before, although back then, I did not > have an user of the pre-declared MDIO board information, but now we do. Note > that I have additional changes queued up to have b53 register platform data > for > MIPS bcm47xx and bcm63xx. > > Yes I know that we should have the Orion platforms eventually be converted to > Device Tree, but until that happens, I don't want any remaining users of the > old "dsa" platform device (hence the previous DTS submissions for ARM/mvebu) > and, there will be platforms out there that most likely won't never see DT > coming their way (BCM47xx is almost 100% sure, BCM63xx maybe not in a distant > future). > > We would probably want the whole series to be merged via David Miller's tree > to simplify things. > > Greg, can you Ack/Nack patch 5 since it touched the core LDD? I've NAKed them for now, you need to describe what you are trying to do here, as it doesn't make any sense to me at the moment. thanks, greg k-h
[PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2
Hi all, This is not exactly new, and was sent before, although back then, I did not have an user of the pre-declared MDIO board information, but now we do. Note that I have additional changes queued up to have b53 register platform data for MIPS bcm47xx and bcm63xx. Yes I know that we should have the Orion platforms eventually be converted to Device Tree, but until that happens, I don't want any remaining users of the old "dsa" platform device (hence the previous DTS submissions for ARM/mvebu) and, there will be platforms out there that most likely won't never see DT coming their way (BCM47xx is almost 100% sure, BCM63xx maybe not in a distant future). We would probably want the whole series to be merged via David Miller's tree to simplify things. Greg, can you Ack/Nack patch 5 since it touched the core LDD? Vivien, since some patches did change, I did not apply your Tested-by tag to all patches. Thanks! Changes in v3: - Tested EPROBE_DEFER from a mockup MDIO/DSA switch driver and everything is fine, once the driver finally probes we have access to platform data as expected - added comment above dsa_port_is_valid() that port->name is mandatory for platform data cases - added an extra check in dsa_parse_member() for a NULL pdata pointer - fixed a bunch of checkpatch errors and warnings Changes in v2: - Rebased against latest net-next/master - Moved dev_find_class() to device_find_class() into drivers/base/core.c - Moved dev_to_net_device into net/core/dev.c - Utilize dsa_chip_data directly instead of dsa_platform_data - Augmented dsa_chip_data to be multi-CPU port ready Changes from last submission (few months back): - rebased against latest net-next - do not introduce dsa2_platform_data which was overkill and was meant to allow us to do exaclty the same things with platform data and Device Tree we use the existing dsa_platform_data instead - properly register MDIO devices when the MDIO bus is registered and associate platform_data with them - add a change to the Orion platform code to demonstrate how this can be used Thank you Florian Fainelli (10): net: dsa: Pass device pointer to dsa_register_switch net: dsa: Make most functions take a dsa_port argument net: dsa: Suffix function manipulating device_node with _dn net: dsa: Move ports assignment closer to error checking drivers: base: Add device_find_class() net: dsa: Migrate to device_find_class() net: Relocate dev_to_net_device() into core net: dsa: Add support for platform data net: phy: Allow pre-declaration of MDIO devices ARM: orion: Register DSA switch as a MDIO device arch/arm/mach-orion5x/common.c | 2 +- arch/arm/mach-orion5x/common.h | 4 +- arch/arm/mach-orion5x/rd88f5181l-fxo-setup.c | 7 +- arch/arm/mach-orion5x/rd88f5181l-ge-setup.c | 7 +- arch/arm/mach-orion5x/rd88f6183ap-ge-setup.c | 7 +- arch/arm/mach-orion5x/wnr854t-setup.c| 2 +- arch/arm/mach-orion5x/wrt350n-v2-setup.c | 7 +- arch/arm/plat-orion/common.c | 25 +++- arch/arm/plat-orion/include/plat/common.h| 4 +- drivers/base/core.c | 19 +++ drivers/net/dsa/b53/b53_common.c | 2 +- drivers/net/dsa/mv88e6xxx/chip.c | 11 +- drivers/net/dsa/qca8k.c | 2 +- drivers/net/phy/Makefile | 3 +- drivers/net/phy/mdio-boardinfo.c | 86 + drivers/net/phy/mdio-boardinfo.h | 19 +++ drivers/net/phy/mdio_bus.c | 4 + drivers/net/phy/mdio_device.c| 11 ++ include/linux/device.h | 1 + include/linux/mdio.h | 3 + include/linux/mod_devicetable.h | 1 + include/linux/netdevice.h| 2 + include/linux/phy.h | 19 +++ include/net/dsa.h| 8 +- net/core/dev.c | 19 +++ net/dsa/dsa.c| 53 ++-- net/dsa/dsa2.c | 174 +++ net/dsa/dsa_priv.h | 4 +- 28 files changed, 365 insertions(+), 141 deletions(-) create mode 100644 drivers/net/phy/mdio-boardinfo.c create mode 100644 drivers/net/phy/mdio-boardinfo.h -- 2.9.3
