Re: [PATCH net-next v3 4/4] net: qualcomm: rmnet: Implement fill_info

[David Miller]

From: Subash Abhinov Kasiviswanathan 
Date: Wed, 14 Mar 2018 13:01:04 -0600

> + if (nla_put_u16(skb, IFLA_VLAN_ID, priv->mux_id))
> + goto nla_put_failure;
> +
> + port = rmnet_get_port_rtnl(real_dev);
> +
> + f.flags = port->data_format;
> + f.mask  = ~0;
> +
> + if (nla_put(skb, IFLA_VLAN_FLAGS, sizeof(f), &f))
> + goto nla_put_failure;

Please don't use VLAN netlink attributes to report rmnet device
specific values.

Instead, please add appropriate new netlink attributes which
clearly show that they are the rmnet mux_id and flags.  You'll
also need to provide UAPI definitions for these flag bits
to go along with the attribute name.

Thanks.

[PATCH net-next v3 4/4] net: qualcomm: rmnet: Implement fill_info

[Subash Abhinov Kasiviswanathan]

This is needed to query the mux_id and flags of a rmnet device.

Signed-off-by: Subash Abhinov Kasiviswanathan 
---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 30 ++
 1 file changed, 30 insertions(+)

diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c 
b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
index 096301a..d0f3e0f 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
@@ -331,6 +331,35 @@ static size_t rmnet_get_size(const struct net_device *dev)
   nla_total_size(sizeof(struct ifla_vlan_flags)); /* 
IFLA_VLAN_FLAGS */
 }
 
+static int rmnet_fill_info(struct sk_buff *skb, const struct net_device *dev)
+{
+   struct rmnet_priv *priv = netdev_priv(dev);
+   struct net_device *real_dev;
+   struct ifla_vlan_flags f;
+   struct rmnet_port *port;
+
+   real_dev = priv->real_dev;
+
+   if (!rmnet_is_real_dev_registered(real_dev))
+   return -ENODEV;
+
+   if (nla_put_u16(skb, IFLA_VLAN_ID, priv->mux_id))
+   goto nla_put_failure;
+
+   port = rmnet_get_port_rtnl(real_dev);
+
+   f.flags = port->data_format;
+   f.mask  = ~0;
+
+   if (nla_put(skb, IFLA_VLAN_FLAGS, sizeof(f), &f))
+   goto nla_put_failure;
+
+   return 0;
+
+nla_put_failure:
+   return -EMSGSIZE;
+}
+
 struct rtnl_link_ops rmnet_link_ops __read_mostly = {
.kind   = "rmnet",
.maxtype= __IFLA_VLAN_MAX,
@@ -341,6 +370,7 @@ struct rtnl_link_ops rmnet_link_ops __read_mostly = {
.dellink= rmnet_dellink,
.get_size   = rmnet_get_size,
.changelink = rmnet_changelink,
+   .fill_info  = rmnet_fill_info,
 };
 
 /* Needs either rcu_read_lock() or rtnl lock */
-- 
1.9.1