Re: [PATCH net-next v6 0/3] Incorporated all required changes

[David Miller]

From: Manish Kurup 
Date: Mon, 6 Nov 2017 11:52:37 -0500

> Currently, the body of the commit message describes what it is doing
> in each commit patch. Would you like me to add some detail to the
> description of each commit?

This is not what I am asking for.

The header posting for a patch series serves a very important
purpose.  It tells the reader at a high level what the patch
series is doing as a whole, how it is doing it, and why it is
doing it that way.

Re: [PATCH net-next v6 0/3] Incorporated all required changes

[Pieter Jansen van Vuuren]

On Mon, 6 Nov 2017 11:52:37 -0500
Manish Kurup  wrote:

> Hi Dave,
> 
> On Sun, Nov 5, 2017 at 8:08 AM, David Miller  wrote:
> 
> > From: Manish Kurup 
> > Date: Fri,  3 Nov 2017 11:49:19 -0400
> >  
> > > Modified the netronome drivers (flower action) to use the VLAN helper
> > > functions instead of dereferencing the structure directly. This is
> > > required for the VLAN action patch.
> > >
> > > Could you please review?  
> >
> > Please use a more appropriate patch series header posting than this.
> >
> > This subject shall describe what the patch series is about, in much
> > the same style as a normal commit, using appropriate subsystem
> > prefixes and so on.
> >
> > The commit message body must describe what the patch series is doing,
> > how it is doing it, and why it is doing it that way.
> >  
> 
> Mistakenly unicasted my reply (below) to Dave.
> 
> Currently, the body of the commit message describes what it is doing in
> each commit patch. Would you like me to add some detail to the
> description of each commit?
Hi Manish, Your patch series header is "Incorporated all required
changes", could you update this to something more descriptive?

Re: [PATCH net-next v6 0/3] Incorporated all required changes

[David Miller]

From: Manish Kurup 
Date: Fri,  3 Nov 2017 11:49:19 -0400

> Modified the netronome drivers (flower action) to use the VLAN helper
> functions instead of dereferencing the structure directly. This is
> required for the VLAN action patch.
> 
> Could you please review?

Please use a more appropriate patch series header posting than this.

This subject shall describe what the patch series is about, in much
the same style as a normal commit, using appropriate subsystem
prefixes and so on.

The commit message body must describe what the patch series is doing,
how it is doing it, and why it is doing it that way.

[PATCH net-next v6 0/3] Incorporated all required changes

[Manish Kurup]

Hi everyone,

Modified the netronome drivers (flower action) to use the VLAN helper
functions instead of dereferencing the structure directly. This is
required for the VLAN action patch.

Could you please review?

Here're the changes:
v2: Fixed all helper functions to use RCU (rtnl_dereference) - Eric, Jamal
v2: Fixed indentation, extra line nits - Jamal, Jiri
v2: Moved rcu_head to the end of the struct - Jiri
v2: Re-formatted locals to reverse-christmas-tree - Jiri
v2: Removed mismatched spin_lock() - Cong
v2: Removed spin_lock_bh() in tcf_vlan_init, rtnl_dereference() should
suffice - Cong, Jiri
v4: Modified the nfp flower action code to use the VLAN helper functions
instead of referencing the structure directly. Isolated this into a
separate patch - Pieter Jansen
v5: Got rid of the unlikely() for the allocation case - Simon Horman
v6: Added cleanup functions for RCU alloc - Dave Miller

Acked-by: Jamal Hadi Salim 
Acked-by: Jiri Pirko 
Signed-off-by: Manish Kurup 

Manish Kurup (3):
  act_vlan: Change stats update to use per-core stats
  nfp flower action: Modified to use VLAN helper functions
  act_vlan: VLAN action rewrite to use RCU lock/unlock and update

 drivers/net/ethernet/netronome/nfp/flower/action.c |  5 +-
 include/net/tc_act/tc_vlan.h   | 46 +---
 net/sched/act_vlan.c   | 81 +++---
 3 files changed, 94 insertions(+), 38 deletions(-)

-- 
2.7.4