Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

On Mon, Sep 3, 2018 at 10:50 PM, Michael Chan  wrote:
> On Mon, Sep 3, 2018 at 10:01 PM, David Miller  wrote:
>>
>> From: Michael Chan 
>> Date: Mon,  3 Sep 2018 04:23:16 -0400
>>
>> > This short series fixes resource related logic in the driver, mostly
>> > affecting the RDMA driver under corner cases.
>>
>> Series applied, thanks Michael.
>>
>> Do you want patch #3 queued up for -stable?
>
> Yes, please go ahead.  Thanks.

But there is a dependency on patch #2 though.  So #2 needs to be queued as well.

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

On Mon, Sep 3, 2018 at 10:01 PM, David Miller  wrote:
>
> From: Michael Chan 
> Date: Mon,  3 Sep 2018 04:23:16 -0400
>
> > This short series fixes resource related logic in the driver, mostly
> > affecting the RDMA driver under corner cases.
>
> Series applied, thanks Michael.
>
> Do you want patch #3 queued up for -stable?

Yes, please go ahead.  Thanks.

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan 
Date: Mon,  3 Sep 2018 04:23:16 -0400

> This short series fixes resource related logic in the driver, mostly
> affecting the RDMA driver under corner cases.

Series applied, thanks Michael.

Do you want patch #3 queued up for -stable?

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

This short series fixes resource related logic in the driver, mostly
affecting the RDMA driver under corner cases.

Michael Chan (3):
  bnxt_en: Fix firmware signaled resource change logic in open.
  bnxt_en: Clean up unused functions.
  bnxt_en: Do not adjust max_cp_rings by the ones used by RDMA.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c   | 22 +++---
 drivers/net/ethernet/broadcom/bnxt/bnxt.h   |  3 +--
 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c |  7 ---
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c   | 20 
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h   |  1 -
 5 files changed, 20 insertions(+), 33 deletions(-)

-- 
2.5.1

Re: [PATCH net 0/3] bnxt_en: bug fixes.

[David Miller]

From: Michael Chan 
Date: Wed, 23 Aug 2017 19:34:02 -0400

> 3 bug fixes related to XDP ring accounting in bnxt_setup_tc(), freeing
> MSIX vectors when bnxt_re unregisters, and preserving the user-administered
> PF MAC address when disabling SRIOV.

Series applied, thanks.

[PATCH net 0/3] bnxt_en: bug fixes.

[Michael Chan]

3 bug fixes related to XDP ring accounting in bnxt_setup_tc(), freeing
MSIX vectors when bnxt_re unregisters, and preserving the user-administered
PF MAC address when disabling SRIOV.

Michael Chan (3):
  bnxt_en: Fix .ndo_setup_tc() to include XDP rings.
  bnxt_en: Free MSIX vectors when unregistering the device from bnxt_re.
  bnxt_en: Do not setup MAC address in bnxt_hwrm_func_qcaps().

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 41 +++
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c |  2 ++
 2 files changed, 31 insertions(+), 12 deletions(-)

-- 
1.8.3.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan 
Date: Tue, 11 Jul 2017 13:05:33 -0400

> 3 bug fixes in this series.  Fix a crash in bnxt_get_stats64() that can
> happen if the device is closing and freeing the statistics block at the
> same time.  The 2nd one fixes ethtool -L failing when changing from
> combined to non-combined mode or vice versa.  The last one fixes SRIOV
> failure on big-endian systems because we were setting a bitmap wrong in
> a firmware message.

Series applied, thanks Michael.

We really should look into generically taking care of the ->ndo_close()
vs. statistics pulling synchronization so that every driver doesn't
need to have code like this.

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

3 bug fixes in this series.  Fix a crash in bnxt_get_stats64() that can
happen if the device is closing and freeing the statistics block at the
same time.  The 2nd one fixes ethtool -L failing when changing from
combined to non-combined mode or vice versa.  The last one fixes SRIOV
failure on big-endian systems because we were setting a bitmap wrong in
a firmware message.

Michael Chan (3):
  bnxt_en: Fix race conditions in .ndo_get_stats64().
  bnxt_en: Fix bug in ethtool -L.
  bnxt_en: Fix SRIOV on big-endian architecture.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 42 ---
 drivers/net/ethernet/broadcom/bnxt/bnxt.h |  4 ++-
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  3 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c |  2 +-
 4 files changed, 35 insertions(+), 16 deletions(-)

-- 
1.8.3.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan 
Date: Mon,  6 Jun 2016 02:37:13 -0400

> Fix a race condition and VLAN rx acceleration logic.

Series applied.

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

Fix a race condition and VLAN rx acceleration logic.

Michael Chan (3):
  bnxt_en: Fix tx push race condition.
  bnxt_en: Enable and disable RX CTAG and RX STAG VLAN acceleration
together.
  bnxt_en: Simplify VLAN receive logic.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 47 +--
 1 file changed, 26 insertions(+), 21 deletions(-)

-- 
1.8.3.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes for net.

[David Miller]

From: Michael Chan 
Date: Mon, 25 Apr 2016 02:30:48 -0400

> Only use MSIX on VF, and fix rx page buffers on architectures with
> PAGE_SIZE >= 64K.

Series applied, thanks Michael.

[PATCH net 0/3] bnxt_en: Bug fixes for net.

[Michael Chan]

Only use MSIX on VF, and fix rx page buffers on architectures with
PAGE_SIZE >= 64K.

Michael Chan (3):
  bnxt_en: Don't fallback to INTA on VF.
  bnxt_en: Limit RX BD pages to be no bigger than 32K.
  bnxt_en: Divide a page into 32K buffers for the aggregation ring if
necessary.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 53 +++
 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 13 
 2 files changed, 52 insertions(+), 14 deletions(-)

-- 
1.8.3.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan 
Date: Thu, 28 Jan 2016 03:11:19 -0500

> 3 small bug fix patches for net.

Series applied, thanks Michael.

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

3 small bug fix patches for net.

Michael Chan (3):
  bnxt_en: Ring free response from close path should use completion ring
  bnxt_en: Exclude rx_drop_pkts hw counter from the stack's rx_dropped
counter.
  bnxt_en: Fix crash in bnxt_free_tx_skbs() during tx timeout.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

-- 
1.8.3.1