Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

[Or Gerlitz]

On 3/12/2018 4:48 AM, David Miller wrote:
> Ok, queued up.

thank you 

Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

[David Miller]

From: Or Gerlitz 
Date: Sun, 11 Mar 2018 11:16:44 +0200

> On 3/7/2018 6:23 PM, David Miller wrote:
>> From: Paul Blakey 
>> Date: Wed,  7 Mar 2018 16:00:11 +0200
>> 
>>> On our mlx5 driver fs_core.c, we use the rhltable interface to store
>>> flow groups. We noticed that sometimes we get a warning that flow group 
>>> isn't
>>> found at removal. This rare case was caused when a specific scenario 
>>> happened,
>>> insertion of a flow group with a similar match criteria (a duplicate),
>>> but only where the flow group rhash_head was second (or not first)
>>> on the relevant rhashtable bucket list.
> 
>> I already applied v3, sorry.  But I did add Herbert's ACKs.
> 
> Hi Dave,
> 
> In mlx5 we use this facility since 4.14, can you please push to
> -stable of at least 4.14 if not earlier?

Ok, queued up.

Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

[Or Gerlitz]

On 3/7/2018 6:23 PM, David Miller wrote:
> From: Paul Blakey 
> Date: Wed,  7 Mar 2018 16:00:11 +0200
> 
>> On our mlx5 driver fs_core.c, we use the rhltable interface to store
>> flow groups. We noticed that sometimes we get a warning that flow group isn't
>> found at removal. This rare case was caused when a specific scenario 
>> happened,
>> insertion of a flow group with a similar match criteria (a duplicate),
>> but only where the flow group rhash_head was second (or not first)
>> on the relevant rhashtable bucket list.

> I already applied v3, sorry.  But I did add Herbert's ACKs.

Hi Dave,

In mlx5 we use this facility since 4.14, can you please push to -stable of at 
least 4.14 if not earlier?

Or.

Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

[Paul Blakey]

On 07/03/2018 18:23, David Miller wrote:

From: Paul Blakey 
Date: Wed,  7 Mar 2018 16:00:11 +0200


On our mlx5 driver fs_core.c, we use the rhltable interface to store
flow groups. We noticed that sometimes we get a warning that flow group isn't
found at removal. This rare case was caused when a specific scenario happened,
insertion of a flow group with a similar match criteria (a duplicate),
but only where the flow group rhash_head was second (or not first)
on the relevant rhashtable bucket list.

The first patch fixes it, and the second one adds a test that show
it is now working.

Paul.

v4 --> v3 changes:
 * Added Herbert Xu's ack (thanks)
 * Removed extra commit tags


I already applied v3, sorry.  But I did add Herbert's ACKs.
:-)



thanks

Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

[David Miller]

From: Paul Blakey 
Date: Wed,  7 Mar 2018 16:00:11 +0200

> On our mlx5 driver fs_core.c, we use the rhltable interface to store
> flow groups. We noticed that sometimes we get a warning that flow group isn't
> found at removal. This rare case was caused when a specific scenario happened,
> insertion of a flow group with a similar match criteria (a duplicate),
> but only where the flow group rhash_head was second (or not first)
> on the relevant rhashtable bucket list.
> 
> The first patch fixes it, and the second one adds a test that show
> it is now working.
> 
> Paul.
> 
> v4 --> v3 changes:
> * Added Herbert Xu's ack (thanks)
> * Removed extra commit tags

I already applied v3, sorry.  But I did add Herbert's ACKs.
:-)

[PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

[Paul Blakey]

On our mlx5 driver fs_core.c, we use the rhltable interface to store
flow groups. We noticed that sometimes we get a warning that flow group isn't
found at removal. This rare case was caused when a specific scenario happened,
insertion of a flow group with a similar match criteria (a duplicate),
but only where the flow group rhash_head was second (or not first)
on the relevant rhashtable bucket list.

The first patch fixes it, and the second one adds a test that show
it is now working.

Paul.

v4 --> v3 changes:
* Added Herbert Xu's ack (thanks)
* Removed extra commit tags
v3 --> v2 changes:
* Added missing fix in rhashtable_lookup_one code path as well.

v2 --> v1 changes:
* Changed commit messages to better reflect the change

Paul Blakey (2):
  rhashtable: Fix rhlist duplicates insertion
  test_rhashtable: add test case for rhltable with duplicate objects

 include/linux/rhashtable.h |   4 +-
 lib/rhashtable.c   |   4 +-
 lib/test_rhashtable.c  | 134 +
 3 files changed, 140 insertions(+), 2 deletions(-)

-- 
1.8.4.3