Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested
Hi guys, Florian Fainelli f.faine...@gmail.com writes: Changes in v5: - removed an invalid use of the link_update callback in the SF2 driver was appeared after merging net: phy: fixed_phy: handle link-down case - reworded the commit message for patch 2 to make it clear what it fixes and why this is required Initial cover letter from Stas: Hello. Currently the link status auto-negotiation is enabled for any SGMII link with fixed-link DT binding. The regression was reported: https://lkml.org/lkml/2015/7/8/865 Apparently not all HW that implements SGMII protocol, generates the inband status for the auto-negotiation to work. More details here: https://lkml.org/lkml/2015/7/10/206 The following patches reverts to the old behavior by default, which is to not enable the auto-negotiation for fixed-link. The new DT property is added that allows to explicitly request the auto-negotiation. FWIW, I tested this v5 series on mirabox (2 mvneta interfaces using RGMII); both interfaces still work as expected, i.e. no regression on my side. a+ -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested
From: Florian Fainelli f.faine...@gmail.com Date: Mon, 20 Jul 2015 17:49:54 -0700 Changes in v5: - removed an invalid use of the link_update callback in the SF2 driver was appeared after merging net: phy: fixed_phy: handle link-down case - reworded the commit message for patch 2 to make it clear what it fixes and why this is required Series applied, thanks Florian. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested
21.07.2015 03:49, Florian Fainelli пишет: Hi all, Changes in v5: - removed an invalid use of the link_update callback in the SF2 driver was appeared after merging net: phy: fixed_phy: handle link-down case Thanks for bringing this forward! For the future, perhaps it will make sense to also teach phylib to never read link status (including speed) when link is down. Will help to narrow more of such problems. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested
Hi all, Changes in v5: - removed an invalid use of the link_update callback in the SF2 driver was appeared after merging net: phy: fixed_phy: handle link-down case - reworded the commit message for patch 2 to make it clear what it fixes and why this is required Initial cover letter from Stas: Hello. Currently the link status auto-negotiation is enabled for any SGMII link with fixed-link DT binding. The regression was reported: https://lkml.org/lkml/2015/7/8/865 Apparently not all HW that implements SGMII protocol, generates the inband status for the auto-negotiation to work. More details here: https://lkml.org/lkml/2015/7/10/206 The following patches reverts to the old behavior by default, which is to not enable the auto-negotiation for fixed-link. The new DT property is added that allows to explicitly request the auto-negotiation. Florian Fainelli (1): net: dsa: bcm_sf2: Do not override speed settings Stas Sergeev (3): net: phy: fixed_phy: handle link-down case of_mdio: add new DT property 'managed' to specify the PHY management type mvneta: use inband status only when explicitly enabled Documentation/devicetree/bindings/net/ethernet.txt | 4 drivers/net/dsa/bcm_sf2.c | 18 +- drivers/net/ethernet/marvell/mvneta.c | 9 + drivers/net/phy/fixed_phy.c| 8 +--- drivers/of/of_mdio.c | 19 +-- 5 files changed, 32 insertions(+), 26 deletions(-) -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
