Re: [PATCH v06 35/36] uapi linux/tls.h: don't include in user space

2017-09-18 Thread Mikko Rapeli 
On Mon, Sep 04, 2017 at 07:15:11PM +0300, Dmitry V. Levin wrote:
> On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote:
> > On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote:
> > > It is not needed and not part of uapi headers, but causes
> > > user space compilation error:
> > > 
> > > fatal error: net/tcp.h: No such file or directory
> > >  #include 
> > >  ^
> > > 
> > > Signed-off-by: Mikko Rapeli 
> > > Cc: Dave Watson 
> > > Cc: Ilya Lesokhin 
> > > Cc: Aviad Yehezkel 
> > > ---
> > >  include/uapi/linux/tls.h | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h
> > > index cc1d21db35d8..d87c698623f2 100644
> > > --- a/include/uapi/linux/tls.h
> > > +++ b/include/uapi/linux/tls.h
> > > @@ -37,7 +37,9 @@
> > >  #include 
> > >  #include 
> > >  #include 
> > > +#ifdef __KERNEL__
> > >  #include 
> > > +#endif
> > 
> > Let's move it to include/net/tls.h instead.
> 
> So everybody ignored this and *new* uapi header was released
> in a totally unusable form along with v4.13.

Should issues like these be filed into bugzilla instead?

Maybe emails are easier to ignore than bugzilla tickets.

-Mikko

Re: [PATCH v06 35/36] uapi linux/tls.h: don't include in user space

2017-09-04 Thread Dmitry V. Levin 
On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote:
> On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote:
> > It is not needed and not part of uapi headers, but causes
> > user space compilation error:
> > 
> > fatal error: net/tcp.h: No such file or directory
> >  #include 
> >  ^
> > 
> > Signed-off-by: Mikko Rapeli 
> > Cc: Dave Watson 
> > Cc: Ilya Lesokhin 
> > Cc: Aviad Yehezkel 
> > ---
> >  include/uapi/linux/tls.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h
> > index cc1d21db35d8..d87c698623f2 100644
> > --- a/include/uapi/linux/tls.h
> > +++ b/include/uapi/linux/tls.h
> > @@ -37,7 +37,9 @@
> >  #include 
> >  #include 
> >  #include 
> > +#ifdef __KERNEL__
> >  #include 
> > +#endif
> 
> Let's move it to include/net/tls.h instead.

So everybody ignored this and *new* uapi header was released
in a totally unusable form along with v4.13.


-- 
ldv


signature.asc
Description: PGP signature

Re: [PATCH v06 35/36] uapi linux/tls.h: don't include in user space

2017-08-08 Thread Dmitry V. Levin 
On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote:
> It is not needed and not part of uapi headers, but causes
> user space compilation error:
> 
> fatal error: net/tcp.h: No such file or directory
>  #include 
>  ^
> 
> Signed-off-by: Mikko Rapeli 
> Cc: Dave Watson 
> Cc: Ilya Lesokhin 
> Cc: Aviad Yehezkel 
> ---
>  include/uapi/linux/tls.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h
> index cc1d21db35d8..d87c698623f2 100644
> --- a/include/uapi/linux/tls.h
> +++ b/include/uapi/linux/tls.h
> @@ -37,7 +37,9 @@
>  #include 
>  #include 
>  #include 
> +#ifdef __KERNEL__
>  #include 
> +#endif

Let's move it to include/net/tls.h instead.


-- 
ldv


signature.asc
Description: PGP signature

[PATCH v06 35/36] uapi linux/tls.h: don't include in user space

2017-08-06 Thread Mikko Rapeli 
It is not needed and not part of uapi headers, but causes
user space compilation error:

fatal error: net/tcp.h: No such file or directory
 #include 
 ^

Signed-off-by: Mikko Rapeli 
Cc: Dave Watson 
Cc: Ilya Lesokhin 
Cc: Aviad Yehezkel 
---
 include/uapi/linux/tls.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h
index cc1d21db35d8..d87c698623f2 100644
--- a/include/uapi/linux/tls.h
+++ b/include/uapi/linux/tls.h
@@ -37,7 +37,9 @@
 #include 
 #include 
 #include 
+#ifdef __KERNEL__
 #include 
+#endif
 
 /* TLS socket options */
 #define TLS_TX 1   /* Set transmit parameters */
-- 
2.13.3