Re: [PATCH v2] openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD

[Kris Murphy]

Sorry that was incorrect, the commit that added the attribute was in 4.7 
so please add cc: sta...@vger.kernel.org #4.7+



On 3/28/2017 10:22 AM, Kris Murphy wrote:
The issue exists starting with 4.6 so can you add cc: 
sta...@vger.kernel.org #4.6+



On 3/16/2017 2:00 PM, David Miller wrote:

From: Kris Murphy 
Date: Thu, 16 Mar 2017 10:51:28 -0500


Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement
in ip_tun_from_nlattr in order to prevent the default case
returning an error.

Fixes: b46f6ded906e ("libnl: nla_put_be64(): align on a 64-bit area")
Signed-off-by: Kris Murphy 

Applied and queued up for -stable, thanks.

Re: [PATCH v2] openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD

[Kris Murphy]

The issue exists starting with 4.6 so can you add cc: 
sta...@vger.kernel.org #4.6+



On 3/16/2017 2:00 PM, David Miller wrote:

From: Kris Murphy 
Date: Thu, 16 Mar 2017 10:51:28 -0500


Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement
in ip_tun_from_nlattr in order to prevent the default case
returning an error.

Fixes: b46f6ded906e ("libnl: nla_put_be64(): align on a 64-bit area")
Signed-off-by: Kris Murphy 

Applied and queued up for -stable, thanks.

Re: [PATCH v2] openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD

[David Miller]

From: Kris Murphy 
Date: Thu, 16 Mar 2017 10:51:28 -0500

> Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement
> in ip_tun_from_nlattr in order to prevent the default case
> returning an error.
> 
> Fixes: b46f6ded906e ("libnl: nla_put_be64(): align on a 64-bit area")
> Signed-off-by: Kris Murphy 

Applied and queued up for -stable, thanks.

Re: [PATCH v2] openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD

[Joe Stringer]

On 16 March 2017 at 08:51, Kris Murphy  wrote:
> Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement
> in ip_tun_from_nlattr in order to prevent the default case
> returning an error.
>
> Fixes: b46f6ded906e ("libnl: nla_put_be64(): align on a 64-bit area")
> Signed-off-by: Kris Murphy 

Thanks for the fix. In future please also place the target tree (in
this case 'net') in the subject line.

Acked-by: Joe Stringer 

[PATCH v2] openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD

[Kris Murphy]

Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement
in ip_tun_from_nlattr in order to prevent the default case
returning an error.

Fixes: b46f6ded906e ("libnl: nla_put_be64(): align on a 64-bit area")
Signed-off-by: Kris Murphy 
---
 net/openvswitch/flow_netlink.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index 6f5fa50..ceb3f3c 100644
--- a/net/openvswitch/flow_netlink.c
+++ b/net/openvswitch/flow_netlink.c
@@ -665,6 +665,8 @@ static int ip_tun_from_nlattr(const struct nlattr *attr,
tun_flags |= TUNNEL_VXLAN_OPT;
opts_type = type;
break;
+   case OVS_TUNNEL_KEY_ATTR_PAD:
+   break;
default:
OVS_NLERR(log, "Unknown IP tunnel attribute %d",
  type);
-- 
2.7.4