Re: [PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check
On Tue, Apr 10, 2018 at 10:50:43AM -0400, David Miller wrote: > From: Jason Wang > Date: Tue, 10 Apr 2018 14:40:10 +0800 > > > On 2018年04月10日 13:26, Stefan Hajnoczi wrote: > >> v2: > >> * Rewrote the conditional to make the vq access check clearer [Linus] > >> * Added Patch 2 to make the return type consistent and harder to misuse > >> * [Linus] > >> > >> The first patch fixes the vhost virtqueue access check which was > >> recently > >> broken. The second patch replaces the int return type with bool to > >> prevent > >> future bugs. > >> > >> Stefan Hajnoczi (2): > >>vhost: fix vhost_vq_access_ok() log check > >>vhost: return bool from *_access_ok() functions > >> > >> drivers/vhost/vhost.h | 4 +-- > >> drivers/vhost/vhost.c | 70 > >> ++- > >> 2 files changed, 38 insertions(+), 36 deletions(-) > >> > > > > Acked-by: Jason Wang > > This sereis doesn't apply cleanly to the net tree, please respin > and add the appropriate Acks and Fixes: tags that Michael and Jason > have provided. Sorry, will fix. Stefan signature.asc Description: PGP signature
Re: [PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check
From: Jason Wang Date: Tue, 10 Apr 2018 14:40:10 +0800 > On 2018年04月10日 13:26, Stefan Hajnoczi wrote: >> v2: >> * Rewrote the conditional to make the vq access check clearer [Linus] >> * Added Patch 2 to make the return type consistent and harder to misuse >> * [Linus] >> >> The first patch fixes the vhost virtqueue access check which was >> recently >> broken. The second patch replaces the int return type with bool to >> prevent >> future bugs. >> >> Stefan Hajnoczi (2): >>vhost: fix vhost_vq_access_ok() log check >>vhost: return bool from *_access_ok() functions >> >> drivers/vhost/vhost.h | 4 +-- >> drivers/vhost/vhost.c | 70 >> ++- >> 2 files changed, 38 insertions(+), 36 deletions(-) >> > > Acked-by: Jason Wang This sereis doesn't apply cleanly to the net tree, please respin and add the appropriate Acks and Fixes: tags that Michael and Jason have provided. Thank you.
Re: [PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check
On 2018年04月10日 13:26, Stefan Hajnoczi wrote: v2: * Rewrote the conditional to make the vq access check clearer [Linus] * Added Patch 2 to make the return type consistent and harder to misuse [Linus] The first patch fixes the vhost virtqueue access check which was recently broken. The second patch replaces the int return type with bool to prevent future bugs. Stefan Hajnoczi (2): vhost: fix vhost_vq_access_ok() log check vhost: return bool from *_access_ok() functions drivers/vhost/vhost.h | 4 +-- drivers/vhost/vhost.c | 70 ++- 2 files changed, 38 insertions(+), 36 deletions(-) Acked-by: Jason Wang Thanks!
[PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check
v2: * Rewrote the conditional to make the vq access check clearer [Linus] * Added Patch 2 to make the return type consistent and harder to misuse [Linus] The first patch fixes the vhost virtqueue access check which was recently broken. The second patch replaces the int return type with bool to prevent future bugs. Stefan Hajnoczi (2): vhost: fix vhost_vq_access_ok() log check vhost: return bool from *_access_ok() functions drivers/vhost/vhost.h | 4 +-- drivers/vhost/vhost.c | 70 ++- 2 files changed, 38 insertions(+), 36 deletions(-) -- 2.14.3