Re: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

2017-04-07 Thread Corentin Labbe 
On Mon, Apr 03, 2017 at 01:38:47PM +0200, Maxime Ripard wrote:
> On Mon, Apr 03, 2017 at 11:14:40AM +0200, Corentin Labbe wrote:
> > The dwmac-sun8i hardware is present on the pine64
> > It uses an external PHY via RMII.
> > 
> > Signed-off-by: Corentin Labbe 
> 
> Looks fine, but please use "arm64: allwinner: pine64: " as your title
> prefix. It applies to all your other patches (and the arm ones should
> be "arm: : :".
> 

Will fix them

Thanks
Corentin Labbe

Re: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

2017-04-03 Thread Maxime Ripard 
On Mon, Apr 03, 2017 at 11:14:40AM +0200, Corentin Labbe wrote:
> The dwmac-sun8i hardware is present on the pine64
> It uses an external PHY via RMII.
> 
> Signed-off-by: Corentin Labbe 

Looks fine, but please use "arm64: allwinner: pine64: " as your title
prefix. It applies to all your other patches (and the arm ones should
be "arm: : :".

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

[PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

2017-04-03 Thread Corentin Labbe 
The dwmac-sun8i hardware is present on the pine64
It uses an external PHY via RMII.

Signed-off-by: Corentin Labbe 
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 16 
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
index c680ed3..6aee3d5 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
@@ -109,3 +109,19 @@
 &usbphy {
status = "okay";
 };
+
+&mdio {
+   ext_rmii_phy1: ethernet-phy@1 {
+   compatible = "ethernet-phy-ieee802.3-c22";
+   reg = <1>;
+   };
+};
+
+&emac {
+   pinctrl-names = "default";
+   pinctrl-0 = <&rmii_pins>;
+   phy-mode = "rmii";
+   phy-handle = <&ext_rmii_phy1>;
+   status = "okay";
+
+};
-- 
2.10.2