Re: [PATCH v4 iproute2 0/6] Add support for vrf keyword

2016-07-06 Thread Stephen Hemminger
On Wed, 29 Jun 2016 11:26:56 -0700
David Ahern  wrote:

> Currently the syntax for VRF related commands is rather kludgy and
> inconsistent from one subcommand to another. This set adds support
> for the VRF keyword to the link, address, neigh, and route commands
> to improve the user experience listing data associated with vrfs,
> modifying routes or doing a route lookup.
> 
> v4
> - Stephen's comments about patch 1 also apply to patch 5, so updated it
> v3
> - addressed comments from Stephen
> - added documentation updates to patches 2, 3 and 6
> 
> v2
> - rebased to top of tree
> - all checkpatch warnings are usage lines. The change in these
>   patches is consistent with existing code for usage lines
> 
> David Ahern (6):
>   ip vrf: Add name_is_vrf
>   ip link/addr: Add support for vrf keyword
>   ip neigh: Add support for keyword
>   ip route: Change type mask to bitmask
>   ip vrf: Add ipvrf_get_table
>   ip route: Add support for vrf keyword
> 
>  ip/ip_common.h   |   3 ++
>  ip/ipaddress.c   |  12 -
>  ip/iplink.c  |  15 ++-
>  ip/iplink_vrf.c  | 113 
> +++
>  ip/ipneigh.c |  14 +-
>  ip/iproute.c |  43 +++---
>  man/man8/ip-address.8.in |   6 +++
>  man/man8/ip-link.8.in|  10 +
>  man/man8/ip-neighbour.8  |   8 +++-
>  man/man8/ip-route.8.in   |  19 +++-
>  10 files changed, 230 insertions(+), 13 deletions(-)
> 

Applied, thanks for cleaning it up.


[PATCH v4 iproute2 0/6] Add support for vrf keyword

2016-06-29 Thread David Ahern
Currently the syntax for VRF related commands is rather kludgy and
inconsistent from one subcommand to another. This set adds support
for the VRF keyword to the link, address, neigh, and route commands
to improve the user experience listing data associated with vrfs,
modifying routes or doing a route lookup.

v4
- Stephen's comments about patch 1 also apply to patch 5, so updated it
v3
- addressed comments from Stephen
- added documentation updates to patches 2, 3 and 6

v2
- rebased to top of tree
- all checkpatch warnings are usage lines. The change in these
  patches is consistent with existing code for usage lines

David Ahern (6):
  ip vrf: Add name_is_vrf
  ip link/addr: Add support for vrf keyword
  ip neigh: Add support for keyword
  ip route: Change type mask to bitmask
  ip vrf: Add ipvrf_get_table
  ip route: Add support for vrf keyword

 ip/ip_common.h   |   3 ++
 ip/ipaddress.c   |  12 -
 ip/iplink.c  |  15 ++-
 ip/iplink_vrf.c  | 113 +++
 ip/ipneigh.c |  14 +-
 ip/iproute.c |  43 +++---
 man/man8/ip-address.8.in |   6 +++
 man/man8/ip-link.8.in|  10 +
 man/man8/ip-neighbour.8  |   8 +++-
 man/man8/ip-route.8.in   |  19 +++-
 10 files changed, 230 insertions(+), 13 deletions(-)

-- 
2.1.4