RE: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, March 15, 2018 12:57 PM > To: Andrew Lunn <and...@lunn.ch>; Laurentiu Tudor > <laurentiu.tu...@nxp.com>; stuyo...@gmail.com > Cc: Razvan Stefanescu <razvan.stefane...@nxp.com>; > de...@driverdev.osuosl.org; a...@arndb.de; gre...@linuxfoundation.org; > Ioana Ciornei <ioana.cior...@nxp.com>; Alexandru Marginean > <alexandru.margin...@nxp.com>; Alexander Graf <ag...@suse.de>; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver > > On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: > > On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > > > This patchset introduces the Ethernet Switch Driver for Freescale/NXP > SoCs > > > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > > > switch objects discovered on the fsl-mc bus. A description of the driver > > > can be found in the associated README file. > > > > Hi Greg > > > > This code has much better quality than the usual stuff in staging. I > > see no reason not to merge it. > > Yeah. It seems pretty decent. Stuart, Laurentiu, care to comment? > > Meanwhile, netdev and DaveM aren't even on the CC list and they're the > ones to ultimately decide. I'll keep in mind to add Dave M and netdev list on CC for the next contributions. Thank you for the suggestion. Regards, Razvan > > regards, > dan carpenter
Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver
Hi Dan, On 03/15/2018 12:56 PM, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: >> On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: >>> This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs >>> with DPAA2 (DataPath Acceleration Architecture v2). The driver manages >>> switch objects discovered on the fsl-mc bus. A description of the driver >>> can be found in the associated README file. >> >> Hi Greg >> >> This code has much better quality than the usual stuff in staging. I >> see no reason not to merge it. > > Yeah. It seems pretty decent. Stuart, Laurentiu, care to comment? Not sure on what you want us to comment ... > Meanwhile, netdev and DaveM aren't even on the CC list and they're the > ones to ultimately decide. I think we'll post to netdev when we'll be done with the TODOs and start moving the driver out of staging. --- Best Regards, Laurentiu
Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver
On Thu, Mar 15, 2018 at 01:56:42PM +0300, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: > > On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > > > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > > > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > > > switch objects discovered on the fsl-mc bus. A description of the driver > > > can be found in the associated README file. > > > > Hi Greg > > > > This code has much better quality than the usual stuff in staging. I > > see no reason not to merge it. > > Yeah. It seems pretty decent. Stuart, Laurentiu, care to comment? > > Meanwhile, netdev and DaveM aren't even on the CC list and they're the > ones to ultimately decide. The patches are for staging, so it is GregKH who decides at this point, not really DaveM. Andrew
Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver
On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: > On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > > switch objects discovered on the fsl-mc bus. A description of the driver > > can be found in the associated README file. > > Hi Greg > > This code has much better quality than the usual stuff in staging. I > see no reason not to merge it. Yeah. It seems pretty decent. Stuart, Laurentiu, care to comment? Meanwhile, netdev and DaveM aren't even on the CC list and they're the ones to ultimately decide. regards, dan carpenter
Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver
On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > switch objects discovered on the fsl-mc bus. A description of the driver > can be found in the associated README file. Hi Greg This code has much better quality than the usual stuff in staging. I see no reason not to merge it. Andrew
[PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver
This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs with DPAA2 (DataPath Acceleration Architecture v2). The driver manages switch objects discovered on the fsl-mc bus. A description of the driver can be found in the associated README file. The patchset consists of: * A set of libraries containing APIs for configuring and controlling Management Complex (MC) switch objects * The DPAA2 Ethernet Switch driver * Patch adding ethtool support Limitations: * no support for control traffic to/from CPU * only DPSW ports can be added to a bridge Changelog: v2: addressed comments from Bogdan P. v3: addressed comments from Andrew L. (patch 3/6 updated) v4: adjust to moving MC-bus out of staging support adding/deleting multicast entries to/from FDB avoid triggering console stack traces due to benign MC errors refactor TCI setting code to avoid code duplication fix sparse warning v5: addresed comments from Andrew L. (patch 2/6 updated) replace ethsw_irq0_handler() with NULL do not allow adding ports of the same switch to multiple bridges v6: addressed comment from Andrew L. and Greg KH. add port partitioning in the TODO file replace licensing text with SPDX identifier Razvan Stefanescu (6): staging: fsl-dpaa2/ethsw: Add APIs for DPSW object staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver staging: fsl-dpaa2/ethsw: Add ethtool support staging: fsl-dpaa2/ethsw: Add maintainer for Ethernet Switch driver staging: fsl-dpaa2/ethsw: Add README staging: fsl-dpaa2/ethsw: Add TODO MAINTAINERS |6 + drivers/staging/fsl-dpaa2/Kconfig |8 + drivers/staging/fsl-dpaa2/Makefile |1 + drivers/staging/fsl-dpaa2/ethsw/Makefile| 10 + drivers/staging/fsl-dpaa2/ethsw/README | 106 ++ drivers/staging/fsl-dpaa2/ethsw/TODO| 14 + drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h | 346 ++ drivers/staging/fsl-dpaa2/ethsw/dpsw.c | 1123 + drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 586 + drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 182 +++ drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 1508 +++ drivers/staging/fsl-dpaa2/ethsw/ethsw.h | 67 + 12 files changed, 3957 insertions(+) create mode 100644 drivers/staging/fsl-dpaa2/ethsw/Makefile create mode 100644 drivers/staging/fsl-dpaa2/ethsw/README create mode 100644 drivers/staging/fsl-dpaa2/ethsw/TODO create mode 100644 drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h create mode 100644 drivers/staging/fsl-dpaa2/ethsw/dpsw.c create mode 100644 drivers/staging/fsl-dpaa2/ethsw/dpsw.h create mode 100644 drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c create mode 100644 drivers/staging/fsl-dpaa2/ethsw/ethsw.c create mode 100644 drivers/staging/fsl-dpaa2/ethsw/ethsw.h -- 1.9.1
