Re: [PATCHv6 net-next 00/10] OVS conntrack support
On 28 August 2015 at 16:57, Simon Horman simon.hor...@netronome.com wrote:
On Wed, Aug 26, 2015 at 11:31:43AM -0700, Joe Stringer wrote:
The goal of this series is to allow OVS to send packets through the Linux
kernel connection tracker, and subsequently match on fields populated by
conntrack. This functionality is enabled through a new
CONFIG_OPENVSWITCH_CONNTRACK option.
This version addresses the feedback from v5, primarily checking the behaviour
is correct with different configurations such as disabling
CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like
connlabels.
The branch below has been updated with the corresponding userspace pieces:
https://github.com/joestringer/ovs dev/ct_20150818
Hi Joe,
Nice work getting this patchset in order.
I am seeing the following when compiling without NF_CONNTRACK_MARK set.
CC [M] net/openvswitch//conntrack.o
net/openvswitch//conntrack.c: In function ‘__ovs_ct_update_key’:
net/openvswitch//conntrack.c:127:24: error: ‘const struct nf_conn’ has no
member named ‘mark’
key-ct.mark = ct ? ct-mark : 0;
^
net/openvswitch//conntrack.c: In function ‘ovs_ct_set_mark’:
net/openvswitch//conntrack.c:195:26: error: ‘struct nf_conn’ has no member
named ‘mark’
new_mark = ct_mark | (ct-mark ~(mask));
^
net/openvswitch//conntrack.c:196:8: error: ‘struct nf_conn’ has no member
named ‘mark’
if (ct-mark != new_mark) {
^
net/openvswitch//conntrack.c:197:5: error: ‘struct nf_conn’ has no member
named ‘mark’
ct-mark = new_mark;
^
scripts/Makefile.build:258: recipe for target 'net/openvswitch//conntrack.o'
failed
make[1]: *** [net/openvswitch//conntrack.o] Error 1
Makefile:1386: recipe for target '_module_net/openvswitch/' failed
make: *** [_module_net/openvswitch/] Error 2
Thanks for reporting this, I sent a patch.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv6 net-next 00/10] OVS conntrack support
On Wed, Aug 26, 2015 at 11:31:43AM -0700, Joe Stringer wrote:
The goal of this series is to allow OVS to send packets through the Linux
kernel connection tracker, and subsequently match on fields populated by
conntrack. This functionality is enabled through a new
CONFIG_OPENVSWITCH_CONNTRACK option.
This version addresses the feedback from v5, primarily checking the behaviour
is correct with different configurations such as disabling
CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like
connlabels.
The branch below has been updated with the corresponding userspace pieces:
https://github.com/joestringer/ovs dev/ct_20150818
Hi Joe,
Nice work getting this patchset in order.
I am seeing the following when compiling without NF_CONNTRACK_MARK set.
CC [M] net/openvswitch//conntrack.o
net/openvswitch//conntrack.c: In function ‘__ovs_ct_update_key’:
net/openvswitch//conntrack.c:127:24: error: ‘const struct nf_conn’ has no
member named ‘mark’
key-ct.mark = ct ? ct-mark : 0;
^
net/openvswitch//conntrack.c: In function ‘ovs_ct_set_mark’:
net/openvswitch//conntrack.c:195:26: error: ‘struct nf_conn’ has no member
named ‘mark’
new_mark = ct_mark | (ct-mark ~(mask));
^
net/openvswitch//conntrack.c:196:8: error: ‘struct nf_conn’ has no member named
‘mark’
if (ct-mark != new_mark) {
^
net/openvswitch//conntrack.c:197:5: error: ‘struct nf_conn’ has no member named
‘mark’
ct-mark = new_mark;
^
scripts/Makefile.build:258: recipe for target 'net/openvswitch//conntrack.o'
failed
make[1]: *** [net/openvswitch//conntrack.o] Error 1
Makefile:1386: recipe for target '_module_net/openvswitch/' failed
make: *** [_module_net/openvswitch/] Error 2
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv6 net-next 00/10] OVS conntrack support
From: Joe Stringer joestrin...@nicira.com Date: Wed, 26 Aug 2015 11:31:43 -0700 The goal of this series is to allow OVS to send packets through the Linux kernel connection tracker, and subsequently match on fields populated by conntrack. This functionality is enabled through a new CONFIG_OPENVSWITCH_CONNTRACK option. This version addresses the feedback from v5, primarily checking the behaviour is correct with different configurations such as disabling CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like connlabels. The branch below has been updated with the corresponding userspace pieces: https://github.com/joestringer/ovs dev/ct_20150818 Series applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCHv6 net-next 00/10] OVS conntrack support
The goal of this series is to allow OVS to send packets through the Linux kernel connection tracker, and subsequently match on fields populated by conntrack. This functionality is enabled through a new CONFIG_OPENVSWITCH_CONNTRACK option. This version addresses the feedback from v5, primarily checking the behaviour is correct with different configurations such as disabling CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like connlabels. The branch below has been updated with the corresponding userspace pieces: https://github.com/joestringer/ovs dev/ct_20150818 Joe Stringer (10): openvswitch: Serialize acts with original netlink len openvswitch: Move MASKED* macros to datapath.h ipv6: Export nf_ct_frag6_gather() dst: Add __skb_dst_copy() variation openvswitch: Add conntrack action openvswitch: Allow matching on conntrack mark netfilter: Always export nf_connlabels_replace() netfilter: connlabels: Export setting connlabel length openvswitch: Allow matching on conntrack label openvswitch: Allow attaching helpers to ct action include/net/dst.h | 9 +- include/net/netfilter/nf_conntrack_labels.h | 4 + include/uapi/linux/openvswitch.h| 58 +++ net/ipv6/netfilter/nf_conntrack_reasm.c | 1 + net/netfilter/nf_conntrack_labels.c | 34 +- net/netfilter/xt_connlabel.c| 16 +- net/openvswitch/Kconfig | 11 + net/openvswitch/Makefile| 2 + net/openvswitch/actions.c | 229 +++-- net/openvswitch/conntrack.c | 744 net/openvswitch/conntrack.h | 86 net/openvswitch/datapath.c | 86 +++- net/openvswitch/datapath.h | 13 + net/openvswitch/flow.c | 6 +- net/openvswitch/flow.h | 11 +- net/openvswitch/flow_netlink.c | 119 - net/openvswitch/flow_netlink.h | 13 +- net/openvswitch/vport.c | 1 + 18 files changed, 1336 insertions(+), 107 deletions(-) create mode 100644 net/openvswitch/conntrack.c create mode 100644 net/openvswitch/conntrack.h -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
