Re: [Patch net] act_mirred: always release tcf hash

2015-10-05 Thread Jamal Hadi Salim 

On 10/01/15 14:37, Cong Wang wrote:

Align with other tc actions.

Cc: Jamal Hadi Salim 
Signed-off-by: Cong Wang 
Signed-off-by: Cong Wang 


Acked-by: Jamal Hadi Salim 

cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Patch net] act_mirred: always release tcf hash

2015-10-05 Thread David Miller 
From: Cong Wang 
Date: Thu,  1 Oct 2015 11:37:43 -0700

> Align with other tc actions.
> 
> Cc: Jamal Hadi Salim 
> Signed-off-by: Cong Wang 
> Signed-off-by: Cong Wang 

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Patch net] act_mirred: always release tcf hash

2015-10-01 Thread Cong Wang 
Align with other tc actions.

Cc: Jamal Hadi Salim 
Signed-off-by: Cong Wang 
Signed-off-by: Cong Wang 
---
 net/sched/act_mirred.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
index 3e7c51a..2efaf4e 100644
--- a/net/sched/act_mirred.c
+++ b/net/sched/act_mirred.c
@@ -107,10 +107,10 @@ static int tcf_mirred_init(struct net *net, struct nlattr 
*nla,
} else {
if (bind)
return 0;
-   if (!ovr) {
-   tcf_hash_release(a, bind);
+
+   tcf_hash_release(a, bind);
+   if (!ovr)
return -EEXIST;
-   }
}
m = to_mirred(a);
 
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html