Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support
On Tue, Apr 05, 2016 at 03:32:53PM +0800, oulijun wrote: > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 > >> > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++ > > ^^ > > Do you support v1 of RoCE or v1 of your HW? > > > Here, v1 stands for hw, that is, we support v1 of our hw. So you should write hns_roce_hw_v1 and not hns_roce_v1_hw > >> 23 files changed, 10429 insertions(+) > > > > Please appreciate the effort needed to review such large patch and > > invest time and effort to divide this to number of small easy review > > patches. > > > Surely, i have pay attention to the patch, but i consider that it is not > better to > split the patch into small patch. because it will the base function of RoCE. > For your advice, i will make further efforts to taking a discussion how > to reslove the question. Faisal Latif's submission [1] can help you to get inspiration. Also please DON'T submit your patches till you get rid of unrelated functions/macros/defines and DMA operations for register access. [1] https://lwn.net/Articles/668721/ > > thanks > Lijun Ou > > . > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support
Hi, Leon Romanovsky On 2016/4/2 9:58, Leon Romanovsky wrote: > On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: >> The driver for HiSilicon RoCE is a platform driver. >> The driver will support multiple versions of hardware. Currently only "v1" >> for hip06 SoC is supported. >> The driver includes two parts: common driver and hardware-specific >> operations. hns_roce_v1_hw.c and hns_roce_v1_hw.h are files for >> hardware-specific operations only for v1 engine, and other files(.c and .h) >> for common algorithm and common hardware operations. >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu(Xavier) >> Signed-off-by: Znlong >> --- >> MAINTAINERS|8 + >> drivers/infiniband/Kconfig |1 + >> drivers/infiniband/hw/Makefile |1 + >> drivers/infiniband/hw/hisilicon/hns/Kconfig| 10 + >> drivers/infiniband/hw/hisilicon/hns/Makefile |9 + >> drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c | 110 + > > We are not adding name of company (hisilicon) for infiniband HW drivers > drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c > ---> > drivers/infiniband/hw/hns/hns_roce_ah.c > Surely, i will modify the location of RoCE driver code after disscussed in next patch > >> .../infiniband/hw/hisilicon/hns/hns_roce_alloc.c | 239 ++ > ^^ > Please fix you paths. > >> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c | 338 +++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h | 80 + >> .../infiniband/hw/hisilicon/hns/hns_roce_common.h | 308 +++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c | 436 +++ >> .../infiniband/hw/hisilicon/hns/hns_roce_device.h | 794 ++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c | 758 ++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h | 132 + >> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c | 578 >> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h | 112 + >> .../infiniband/hw/hisilicon/hns/hns_roce_main.c| 1097 >> drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c | 605 + >> drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c | 124 + >> drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c | 841 ++ >> .../infiniband/hw/hisilicon/hns/hns_roce_user.h| 31 + >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 >> >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++ > ^^ > Do you support v1 of RoCE or v1 of your HW? > Here, v1 stands for hw, that is, we support v1 of our hw. >> 23 files changed, 10429 insertions(+) > > Please appreciate the effort needed to review such large patch and > invest time and effort to divide this to number of small easy review patches. > Surely, i have pay attention to the patch, but i consider that it is not better to split the patch into small patch. because it will the base function of RoCE. For your advice, i will make further efforts to taking a discussion how to reslove the question. thanks Lijun Ou > . >
Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support
On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: > The driver for HiSilicon RoCE is a platform driver. > The driver will support multiple versions of hardware. Currently only "v1" > for hip06 SoC is supported. > The driver includes two parts: common driver and hardware-specific > operations. hns_roce_v1_hw.c and hns_roce_v1_hw.h are files for > hardware-specific operations only for v1 engine, and other files(.c and .h) > for common algorithm and common hardware operations. > > Signed-off-by: Lijun Ou > Signed-off-by: Wei Hu(Xavier) > Signed-off-by: Znlong > --- > MAINTAINERS|8 + > drivers/infiniband/Kconfig |1 + > drivers/infiniband/hw/Makefile |1 + > drivers/infiniband/hw/hisilicon/hns/Kconfig| 10 + > drivers/infiniband/hw/hisilicon/hns/Makefile |9 + > drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c | 110 + We are not adding name of company (hisilicon) for infiniband HW drivers drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c ---> drivers/infiniband/hw/hns/hns_roce_ah.c > .../infiniband/hw/hisilicon/hns/hns_roce_alloc.c | 239 ++ ^^ Please fix you paths. > drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c | 338 +++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h | 80 + > .../infiniband/hw/hisilicon/hns/hns_roce_common.h | 308 +++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c | 436 +++ > .../infiniband/hw/hisilicon/hns/hns_roce_device.h | 794 ++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c | 758 ++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h | 132 + > drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c | 578 > drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h | 112 + > .../infiniband/hw/hisilicon/hns/hns_roce_main.c| 1097 > drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c | 605 + > drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c | 124 + > drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c | 841 ++ > .../infiniband/hw/hisilicon/hns/hns_roce_user.h| 31 + > .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 > > .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++ ^^ Do you support v1 of RoCE or v1 of your HW? > 23 files changed, 10429 insertions(+) Please appreciate the effort needed to review such large patch and invest time and effort to divide this to number of small easy review patches.