Re: [SOFTMAC] Reduce default rate to 11Mbps.
On Mon, 2006-03-27 at 11:55 -0500, John W. Linville wrote: On Sat, Mar 25, 2006 at 12:58:55AM +, David Woodhouse wrote: On Fri, 2006-03-24 at 08:18 -0800, Jouni Malinen wrote: On Thu, Mar 23, 2006 at 10:43:38PM +, David Woodhouse wrote: This patch makes us default to 11M, which ought to work for most people. Is this code supposed to work with IEEE 802.11a (which would also use OFDM modulation)? If yes, please note that 11 Mbps is not a valid IEEE 802.11a TX rate. Er, well spotted. Let's do it like this instead... Is everyone OK w/ David's latest patch? +1 looks good to me Dan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SOFTMAC] Reduce default rate to 11Mbps.
On Mon, Mar 27, 2006 at 12:25:47PM -0500, Dan Williams wrote: On Mon, 2006-03-27 at 11:55 -0500, John W. Linville wrote: On Sat, Mar 25, 2006 at 12:58:55AM +, David Woodhouse wrote: On Fri, 2006-03-24 at 08:18 -0800, Jouni Malinen wrote: On Thu, Mar 23, 2006 at 10:43:38PM +, David Woodhouse wrote: This patch makes us default to 11M, which ought to work for most people. Is this code supposed to work with IEEE 802.11a (which would also use OFDM modulation)? If yes, please note that 11 Mbps is not a valid IEEE 802.11a TX rate. Er, well spotted. Let's do it like this instead... Is everyone OK w/ David's latest patch? +1 looks good to me Merged to the 'upstream' branch of wireless-2.6. Thanks! John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SOFTMAC] Reduce default rate to 11Mbps.
On Thu, Mar 23, 2006 at 10:43:38PM +, David Woodhouse wrote: This patch makes us default to 11M, which ought to work for most people. Is this code supposed to work with IEEE 802.11a (which would also use OFDM modulation)? If yes, please note that 11 Mbps is not a valid IEEE 802.11a TX rate. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SOFTMAC] Reduce default rate to 11Mbps.
On Fri, 2006-03-24 at 08:18 -0800, Jouni Malinen wrote:
On Thu, Mar 23, 2006 at 10:43:38PM +, David Woodhouse wrote:
This patch makes us default to 11M, which ought to work for most people.
Is this code supposed to work with IEEE 802.11a (which would also use
OFDM modulation)? If yes, please note that 11 Mbps is not a valid IEEE
802.11a TX rate.
Er, well spotted. Let's do it like this instead...
diff --git a/net/ieee80211/softmac/ieee80211softmac_module.c
b/net/ieee80211/softmac/ieee80211softmac_module.c
index 6f99f78..60f06a3 100644
--- a/net/ieee80211/softmac/ieee80211softmac_module.c
+++ b/net/ieee80211/softmac/ieee80211softmac_module.c
@@ -183,16 +183,21 @@ void ieee80211softmac_start(struct net_d
*/
if (mac-txrates_change)
oldrates = mac-txrates;
- if (ieee-modulation IEEE80211_OFDM_MODULATION) {
- mac-txrates.default_rate = IEEE80211_OFDM_RATE_54MB;
- change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT;
- mac-txrates.default_fallback = IEEE80211_OFDM_RATE_24MB;
- change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT_FBACK;
- } else if (ieee-modulation IEEE80211_CCK_MODULATION) {
+ /* FIXME: We don't correctly handle backing down to lower
+ rates, so 801.11g devices start off at 11M for now. People
+ can manually change it if they really need to, but 11M is
+ more reliable. Note similar logic in
+ ieee80211softmac_wx_set_rate() */
+ if (ieee-modulation IEEE80211_CCK_MODULATION) {
mac-txrates.default_rate = IEEE80211_CCK_RATE_11MB;
change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT;
mac-txrates.default_fallback = IEEE80211_CCK_RATE_5MB;
change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT_FBACK;
+ } else if (ieee-modulation IEEE80211_OFDM_MODULATION) {
+ mac-txrates.default_rate = IEEE80211_OFDM_RATE_54MB;
+ change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT;
+ mac-txrates.default_fallback = IEEE80211_OFDM_RATE_24MB;
+ change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT_FBACK;
} else
assert(0);
if (mac-txrates_change)
diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c
b/net/ieee80211/softmac/ieee80211softmac_wx.c
index e1a9bc6..b559aa9 100644
--- a/net/ieee80211/softmac/ieee80211softmac_wx.c
+++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
@@ -135,11 +135,15 @@ ieee80211softmac_wx_set_rate(struct net_
int err = -EINVAL;
if (in_rate == -1) {
- /* automatic detect */
- if (ieee-modulation IEEE80211_OFDM_MODULATION)
- in_rate = 5400;
- else
+ /* FIXME: We don't correctly handle backing down to lower
+ rates, so 801.11g devices start off at 11M for now. People
+ can manually change it if they really need to, but 11M is
+ more reliable. Note similar logic in
+ ieee80211softmac_wx_set_rate() */
+ if (ieee-modulation IEEE80211_CCK_MODULATION)
in_rate = 1100;
+ else
+ in_rate = 5400;
}
switch (in_rate) {
--
dwmw2
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[SOFTMAC] Reduce default rate to 11Mbps.
We aren't particularly good at noticing when 54Mbps connections aren't
reliable and backing down to slower speeds. This patch changes the
default to 11Mbps.
It's possible we'd want to leave it like this anyway -- even when we can
handle dynamic rate adjustment, it might make sense to start at 11Mbps
and then tune it up or down from there, rather than starting at 54Mbps.
Signed-off-by: David Woodhouse [EMAIL PROTECTED]
--- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_module.c~
2006-03-21 23:50:00.0 +
+++ linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_module.c
2006-03-22 11:00:57.0 +
@@ -183,7 +183,10 @@ void ieee80211softmac_start(struct net_d
*/
if (mac-txrates_change)
oldrates = mac-txrates;
- if (ieee-modulation IEEE80211_OFDM_MODULATION) {
+ /* FIXME: We don't correctly handle backing down to lower rates,
+ so start off at 11M for now. People can manually change it if
+ they really need to, but 11M is more reliable. */
+ if (0 ieee-modulation IEEE80211_OFDM_MODULATION) {
mac-txrates.default_rate = IEEE80211_OFDM_RATE_54MB;
change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT;
mac-txrates.default_fallback = IEEE80211_OFDM_RATE_24MB;
--- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_wx.c~
2006-03-21 23:50:00.0 +
+++ linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_wx.c
2006-03-22 12:11:58.0 +
@@ -136,7 +136,7 @@ ieee80211softmac_wx_set_rate(struct net_
if (in_rate == -1) {
/* automatic detect */
- if (ieee-modulation IEEE80211_OFDM_MODULATION)
+ if (0 ieee-modulation IEEE80211_OFDM_MODULATION)
in_rate = 5400;
else
in_rate = 1100;
--
dwmw2
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SOFTMAC] Reduce default rate to 11Mbps.
On Thu, 2006-03-23 at 13:58 +, David Woodhouse wrote:
We aren't particularly good at noticing when 54Mbps connections aren't
reliable and backing down to slower speeds. This patch changes the
default to 11Mbps.
It's possible we'd want to leave it like this anyway -- even when we can
handle dynamic rate adjustment, it might make sense to start at 11Mbps
and then tune it up or down from there, rather than starting at 54Mbps.
Signed-off-by: David Woodhouse [EMAIL PROTECTED]
--- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_module.c~
2006-03-21 23:50:00.0 +
+++ linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_module.c
2006-03-22 11:00:57.0 +
@@ -183,7 +183,10 @@ void ieee80211softmac_start(struct net_d
*/
if (mac-txrates_change)
oldrates = mac-txrates;
- if (ieee-modulation IEEE80211_OFDM_MODULATION) {
+ /* FIXME: We don't correctly handle backing down to lower rates,
+so start off at 11M for now. People can manually change it if
+they really need to, but 11M is more reliable. */
+ if (0 ieee-modulation IEEE80211_OFDM_MODULATION) {
mac-txrates.default_rate = IEEE80211_OFDM_RATE_54MB;
change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT;
mac-txrates.default_fallback = IEEE80211_OFDM_RATE_24MB;
--- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_wx.c~
2006-03-21 23:50:00.0 +
+++ linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_wx.c
2006-03-22 12:11:58.0 +
@@ -136,7 +136,7 @@ ieee80211softmac_wx_set_rate(struct net_
if (in_rate == -1) {
/* automatic detect */
- if (ieee-modulation IEEE80211_OFDM_MODULATION)
+ if (0 ieee-modulation IEEE80211_OFDM_MODULATION)
in_rate = 5400;
else
in_rate = 1100;
Seems like the comment from hunk 1 should go there too. If I see a
random if (0 ...) in code somewhere then I've got no idea why just
looking at the code.
Dan
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SOFTMAC] Reduce default rate to 11Mbps.
On Thu, Mar 23, 2006 at 02:37:35PM -0500, Dan Williams wrote:
On Thu, 2006-03-23 at 13:58 +, David Woodhouse wrote:
We aren't particularly good at noticing when 54Mbps connections aren't
reliable and backing down to slower speeds. This patch changes the
default to 11Mbps.
It's possible we'd want to leave it like this anyway -- even when we can
handle dynamic rate adjustment, it might make sense to start at 11Mbps
and then tune it up or down from there, rather than starting at 54Mbps.
Signed-off-by: David Woodhouse [EMAIL PROTECTED]
--- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_module.c~
2006-03-21 23:50:00.0 +
+++ linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_module.c
2006-03-22 11:00:57.0 +
@@ -183,7 +183,10 @@ void ieee80211softmac_start(struct net_d
*/
if (mac-txrates_change)
oldrates = mac-txrates;
- if (ieee-modulation IEEE80211_OFDM_MODULATION) {
+ /* FIXME: We don't correctly handle backing down to lower rates,
+ so start off at 11M for now. People can manually change it if
+ they really need to, but 11M is more reliable. */
+ if (0 ieee-modulation IEEE80211_OFDM_MODULATION) {
mac-txrates.default_rate = IEEE80211_OFDM_RATE_54MB;
change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT;
mac-txrates.default_fallback = IEEE80211_OFDM_RATE_24MB;
--- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_wx.c~
2006-03-21 23:50:00.0 +
+++ linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_wx.c
2006-03-22 12:11:58.0 +
@@ -136,7 +136,7 @@ ieee80211softmac_wx_set_rate(struct net_
if (in_rate == -1) {
/* automatic detect */
- if (ieee-modulation IEEE80211_OFDM_MODULATION)
+ if (0 ieee-modulation IEEE80211_OFDM_MODULATION)
in_rate = 5400;
else
in_rate = 1100;
Seems like the comment from hunk 1 should go there too. If I see a
random if (0 ...) in code somewhere then I've got no idea why just
looking at the code.
Dan makes a good point. Ideally, the FIXME comments should refer to
each other as well.
I'm redoing the wireless-2.6 tree to back-out this patch. (I think
that is best, since I don't think Jeff has pulled it yet.)
Please do resubmit the patch w/ the comment changes. I'd also like
to see the outcome of the related discussion on the bcm43xx-dev list.
John
--
John W. Linville
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SOFTMAC] Reduce default rate to 11Mbps.
On Thu, 2006-03-23 at 16:04 -0500, John W. Linville wrote:
Please do resubmit the patch w/ the comment changes.
Below.
I'd also like to see the outcome of the related discussion on the
bcm43xx-dev list.
The discussion with Hans? I'm not sure that's really related to the
rates -- that's more to do with the other initialisation stuff, like
actually trying to associate when dhclient brings the interface up.
---
We don't make much of an attempt to fall back to lower rates, and 54M
just isn't reliable enough for many people. In fact, it's not clear we
even set it to 11M if we're trying to associate with an 802.11b AP.
This patch makes us default to 11M, which ought to work for most people.
When we actually handle dynamic rate adjustment, we can reconsider the
defaults -- but even then, probably it makes as much sense to start at
11M and adjust it upwards as it does to start at 54M and reduce it.
Signed-off-by: David Woodhouse [EMAIL PROTECTED]
diff --git a/net/ieee80211/softmac/ieee80211softmac_module.c
b/net/ieee80211/softmac/ieee80211softmac_module.c
index 6f99f78..9ba9eec 100644
--- a/net/ieee80211/softmac/ieee80211softmac_module.c
+++ b/net/ieee80211/softmac/ieee80211softmac_module.c
@@ -183,7 +183,11 @@ void ieee80211softmac_start(struct net_d
*/
if (mac-txrates_change)
oldrates = mac-txrates;
- if (ieee-modulation IEEE80211_OFDM_MODULATION) {
+ /* FIXME: We don't correctly handle backing down to lower rates,
+ so start off at 11M for now. People can manually change it if
+ they really need to, but 11M is more reliable. Note similar
+ logic in ieee80211softmac_wx_set_rate() */
+ if (0 ieee-modulation IEEE80211_OFDM_MODULATION) {
mac-txrates.default_rate = IEEE80211_OFDM_RATE_54MB;
change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT;
mac-txrates.default_fallback = IEEE80211_OFDM_RATE_24MB;
diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c
b/net/ieee80211/softmac/ieee80211softmac_wx.c
index e1a9bc6..733d808 100644
--- a/net/ieee80211/softmac/ieee80211softmac_wx.c
+++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
@@ -135,8 +135,11 @@ ieee80211softmac_wx_set_rate(struct net_
int err = -EINVAL;
if (in_rate == -1) {
- /* automatic detect */
- if (ieee-modulation IEEE80211_OFDM_MODULATION)
+ /* FIXME: We don't correctly handle backing down to lower rates,
+ so start off at 11M for now. People can manually change it if
+ they really need to, but 11M is more reliable. Note similar
+ logic in ieee80211softmac_start() */
+ if (0 ieee-modulation IEEE80211_OFDM_MODULATION)
in_rate = 5400;
else
in_rate = 1100;
--
dwmw2
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
