Re: [bpf PATCH v2 0/2] sockmap, syzbot fix error path and RCU fix

2018-07-07 Thread Alexei Starovoitov 
On Thu, Jul 05, 2018 at 08:05:51AM -0700, John Fastabend wrote:
> I missed fixing the error path in the sockhash code to align with
> supporting socks in multiple maps. Simply checking if the psock is
> present does not mean we can decrement the reference count because
> it could be part of another map. Fix this by cleaning up the error
> path so this situation does not happen.

Applied, Thanks

[bpf PATCH v2 0/2] sockmap, syzbot fix error path and RCU fix

2018-07-05 Thread John Fastabend 
I missed fixing the error path in the sockhash code to align with
supporting socks in multiple maps. Simply checking if the psock is
present does not mean we can decrement the reference count because
it could be part of another map. Fix this by cleaning up the error
path so this situation does not happen.

---

John Fastabend (2):
  bpf: sockmap, error path can not release psock in multi-map case
  bpf: sockmap, hash table is RCU so readers do not need locks


 kernel/bpf/sockmap.c |   19 ++-
 1 file changed, 6 insertions(+), 13 deletions(-)

--
Signature