Re: [net-next:master 17/24] DockBook: net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'

2016-06-04 Thread Marcelo Ricardo Leitner 

Em 04-06-2016 02:57, David Miller escreveu:

From: kbuild test robot 
Date: Sat, 4 Jun 2016 08:48:17 +0800


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
master
head:   330348d94223346f855357fab2517f6c903001c7
commit: ae7ef81ef000adeee7a87585b9135ff8a8064acc [17/24] skbuff: introduce 
skb_gso_validate_mtu
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   include/linux/skbuff.h:928: warning: No description found for parameter 'sk'
   include/net/sock.h:449: warning: No description found for parameter 
'sk_padding'
   include/net/sock.h:449: warning: No description found for parameter 'sk_rcu'

net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'

   net/core/gen_stats.c:65: warning: No description found for parameter 
'padattr'
   net/core/gen_stats.c:100: warning: No description found for parameter 
'padattr'


Fixed as follows:


net: Add docbook description for 'mtu' arg to skb_gso_validate_mtu()

Signed-off-by: David S. Miller 
---
 net/core/skbuff.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index b6e0f95..e7ec6d3 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4399,6 +4399,7 @@ EXPORT_SYMBOL_GPL(skb_gso_transport_seglen);
  * skb_gso_validate_mtu - Return in case such skb fits a given MTU
  *
  * @skb: GSO skb
+ * @mtu: MTU to validate against
  *
  * skb_gso_validate_mtu validates if a given skb will fit a wanted MTU
  * once split.



Thanks David.

Re: [net-next:master 17/24] DockBook: net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'

2016-06-03 Thread David Miller 
From: kbuild test robot 
Date: Sat, 4 Jun 2016 08:48:17 +0800

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
> master
> head:   330348d94223346f855357fab2517f6c903001c7
> commit: ae7ef81ef000adeee7a87585b9135ff8a8064acc [17/24] skbuff: introduce 
> skb_gso_validate_mtu
> reproduce: make htmldocs
> 
> All warnings (new ones prefixed by >>):
> 
>include/linux/skbuff.h:928: warning: No description found for parameter 
> 'sk'
>include/net/sock.h:449: warning: No description found for parameter 
> 'sk_padding'
>include/net/sock.h:449: warning: No description found for parameter 
> 'sk_rcu'
>>> net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'
>net/core/gen_stats.c:65: warning: No description found for parameter 
> 'padattr'
>net/core/gen_stats.c:100: warning: No description found for parameter 
> 'padattr'

Fixed as follows:


net: Add docbook description for 'mtu' arg to skb_gso_validate_mtu()

Signed-off-by: David S. Miller 
---
 net/core/skbuff.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index b6e0f95..e7ec6d3 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4399,6 +4399,7 @@ EXPORT_SYMBOL_GPL(skb_gso_transport_seglen);
  * skb_gso_validate_mtu - Return in case such skb fits a given MTU
  *
  * @skb: GSO skb
+ * @mtu: MTU to validate against
  *
  * skb_gso_validate_mtu validates if a given skb will fit a wanted MTU
  * once split.
-- 
2.1.0

[net-next:master 17/24] DockBook: net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'

2016-06-03 Thread kbuild test robot 
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
master
head:   330348d94223346f855357fab2517f6c903001c7
commit: ae7ef81ef000adeee7a87585b9135ff8a8064acc [17/24] skbuff: introduce 
skb_gso_validate_mtu
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   include/linux/skbuff.h:928: warning: No description found for parameter 'sk'
   include/net/sock.h:449: warning: No description found for parameter 
'sk_padding'
   include/net/sock.h:449: warning: No description found for parameter 'sk_rcu'
>> net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'
   net/core/gen_stats.c:65: warning: No description found for parameter 
'padattr'
   net/core/gen_stats.c:100: warning: No description found for parameter 
'padattr'

vim +/mtu +4404 net/core/skbuff.c

  4388   * payload, i.e. the size of the L4 (UDP) header is already
  4389   * accounted for.
  4390   */
  4391  return thlen + shinfo->gso_size;
  4392  }
  4393  EXPORT_SYMBOL_GPL(skb_gso_transport_seglen);
  4394  
  4395  /**
  4396   * skb_gso_validate_mtu - Return in case such skb fits a given MTU
  4397   *
  4398   * @skb: GSO skb
  4399   *
  4400   * skb_gso_validate_mtu validates if a given skb will fit a wanted MTU
  4401   * once split.
  4402   */
  4403  bool skb_gso_validate_mtu(const struct sk_buff *skb, unsigned int mtu)
> 4404  {
  4405  const struct skb_shared_info *shinfo = skb_shinfo(skb);
  4406  const struct sk_buff *iter;
  4407  unsigned int hlen;
  4408  
  4409  hlen = skb_gso_network_seglen(skb);
  4410  
  4411  if (shinfo->gso_size != GSO_BY_FRAGS)
  4412  return hlen <= mtu;

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: Binary data