Re: [net-next 01/13] i40evf: fix client warnings

[David Miller]

From: Jeff Kirsher 
Date: Tue, 14 Mar 2017 17:44:44 -0700

> On Tue, 2017-03-14 at 17:39 -0700, David Miller wrote:
>> From: Jeff Kirsher 
>> Date: Tue, 14 Mar 2017 15:32:56 -0700
>> 
>> > From: Faisal Latif 
>> > 
>> > The function prototype in i40evf_client.h are giving warnings while
>> > compiling i40iwvf module. Move these function prototypes to
>> > i40evf.h.
>> > Also fix return code from u32 to int and this return code is
>> > consistent with i40e_client.h
>> > 
>> > Change-Id: Ie3757f844993aabc27654aaf02ec14fb985ad2c4
>> > Signed-off-by: Faisal Latif 
>> > Tested-by: Andrew Bowers 
>> > Signed-off-by: Jeff Kirsher 
>> 
>> There is no such i40evf_client.h header file in the tree.
> 
> Not sure how this got out of order, Mitch adds this file in patch #4

Ok, please fix the order so that the dependencies are correct.

Thanks.

Re: [net-next 01/13] i40evf: fix client warnings

[Jeff Kirsher]

On Tue, 2017-03-14 at 17:39 -0700, David Miller wrote:
> From: Jeff Kirsher 
> Date: Tue, 14 Mar 2017 15:32:56 -0700
> 
> > From: Faisal Latif 
> > 
> > The function prototype in i40evf_client.h are giving warnings while
> > compiling i40iwvf module. Move these function prototypes to
> > i40evf.h.
> > Also fix return code from u32 to int and this return code is
> > consistent with i40e_client.h
> > 
> > Change-Id: Ie3757f844993aabc27654aaf02ec14fb985ad2c4
> > Signed-off-by: Faisal Latif 
> > Tested-by: Andrew Bowers 
> > Signed-off-by: Jeff Kirsher 
> 
> There is no such i40evf_client.h header file in the tree.

Not sure how this got out of order, Mitch adds this file in patch #4

> 
> >   int i40evf_config_rss(struct i40evf_adapter *adapter);
> > +int i40evf_lan_add_device(struct i40evf_adapter *adapter);
> > +int i40evf_lan_del_device(struct i40evf_adapter *adapter);
> > +void i40evf_client_subtask(struct i40evf_adapter *adapter);
> > +void i40evf_notify_client_message(struct i40e_vsi *vsi, u8 *msg,
> > u16 len);
> > +void i40evf_notify_client_l2_params(struct i40e_vsi *vsi);
> > +void i40evf_notify_client_open(struct i40e_vsi *vsi);
> > +void i40evf_notify_client_close(struct i40e_vsi *vsi);
> >   #endif /* _I40EVF_H_ */
> 
> And these functions do not exist in the tree either.
> 
> This really isn't acceptable.



signature.asc
Description: This is a digitally signed message part

Re: [net-next 01/13] i40evf: fix client warnings

[David Miller]

From: Jeff Kirsher 
Date: Tue, 14 Mar 2017 15:32:56 -0700

> From: Faisal Latif 
> 
> The function prototype in i40evf_client.h are giving warnings while
> compiling i40iwvf module. Move these function prototypes to i40evf.h.
> Also fix return code from u32 to int and this return code is
> consistent with i40e_client.h
> 
> Change-Id: Ie3757f844993aabc27654aaf02ec14fb985ad2c4
> Signed-off-by: Faisal Latif 
> Tested-by: Andrew Bowers 
> Signed-off-by: Jeff Kirsher 

There is no such i40evf_client.h header file in the tree.

>  int i40evf_config_rss(struct i40evf_adapter *adapter);
> +int i40evf_lan_add_device(struct i40evf_adapter *adapter);
> +int i40evf_lan_del_device(struct i40evf_adapter *adapter);
> +void i40evf_client_subtask(struct i40evf_adapter *adapter);
> +void i40evf_notify_client_message(struct i40e_vsi *vsi, u8 *msg, u16 len);
> +void i40evf_notify_client_l2_params(struct i40e_vsi *vsi);
> +void i40evf_notify_client_open(struct i40e_vsi *vsi);
> +void i40evf_notify_client_close(struct i40e_vsi *vsi);
>  #endif /* _I40EVF_H_ */

And these functions do not exist in the tree either.

This really isn't acceptable.

[net-next 01/13] i40evf: fix client warnings

[Jeff Kirsher]

From: Faisal Latif 

The function prototype in i40evf_client.h are giving warnings while
compiling i40iwvf module. Move these function prototypes to i40evf.h.
Also fix return code from u32 to int and this return code is
consistent with i40e_client.h

Change-Id: Ie3757f844993aabc27654aaf02ec14fb985ad2c4
Signed-off-by: Faisal Latif 
Tested-by: Andrew Bowers 
Signed-off-by: Jeff Kirsher 
---
 drivers/net/ethernet/intel/i40evf/i40evf.h | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h 
b/drivers/net/ethernet/intel/i40evf/i40evf.h
index 00c42d803276..f16d9d1ec403 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf.h
+++ b/drivers/net/ethernet/intel/i40evf/i40evf.h
@@ -337,4 +337,11 @@ void i40evf_virtchnl_completion(struct i40evf_adapter 
*adapter,
enum i40e_virtchnl_ops v_opcode,
i40e_status v_retval, u8 *msg, u16 msglen);
 int i40evf_config_rss(struct i40evf_adapter *adapter);
+int i40evf_lan_add_device(struct i40evf_adapter *adapter);
+int i40evf_lan_del_device(struct i40evf_adapter *adapter);
+void i40evf_client_subtask(struct i40evf_adapter *adapter);
+void i40evf_notify_client_message(struct i40e_vsi *vsi, u8 *msg, u16 len);
+void i40evf_notify_client_l2_params(struct i40e_vsi *vsi);
+void i40evf_notify_client_open(struct i40e_vsi *vsi);
+void i40evf_notify_client_close(struct i40e_vsi *vsi);
 #endif /* _I40EVF_H_ */
-- 
2.12.0