From: Alan Cox <a...@linux.intel.com>

The only error case is when the malloc fails, in which case the clean up
loop does nothing at all, so remove it

Signed-off-by: Alan Cox <a...@linux.intel.com>
Tested-by: Andrew Bowers <andrewx.bow...@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
---
 drivers/net/ethernet/intel/i40evf/i40evf_main.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c 
b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 4b70aae..820ad94 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -1507,7 +1507,7 @@ static int i40evf_alloc_q_vectors(struct i40evf_adapter 
*adapter)
        adapter->q_vectors = kcalloc(num_q_vectors, sizeof(*q_vector),
                                     GFP_KERNEL);
        if (!adapter->q_vectors)
-               goto err_out;
+               return -ENOMEM;
 
        for (q_idx = 0; q_idx < num_q_vectors; q_idx++) {
                q_vector = &adapter->q_vectors[q_idx];
@@ -1519,15 +1519,6 @@ static int i40evf_alloc_q_vectors(struct i40evf_adapter 
*adapter)
        }
 
        return 0;
-
-err_out:
-       while (q_idx) {
-               q_idx--;
-               q_vector = &adapter->q_vectors[q_idx];
-               netif_napi_del(&q_vector->napi);
-       }
-       kfree(adapter->q_vectors);
-       return -ENOMEM;
 }
 
 /**
-- 
2.5.5

Reply via email to