Re: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

2016-09-15 Thread David Miller 
From: Varun Prakash 
Date: Tue, 13 Sep 2016 21:23:55 +0530

> This patch series removes duplicate code from
> iw_cxgb4 and cxgbit by adding common function
> definitions in libcxgb.
> 
> Please review.

Series applied, thanks.

Re: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

2016-09-15 Thread Varun Prakash 
Hi Or,

On Wed, Sep 14, 2016 at 02:02:43PM +0530, Or Gerlitz wrote:
> On Tue, Sep 13, 2016 at 6:53 PM, Varun Prakash  wrote:
> > This patch series removes duplicate code from
> > iw_cxgb4 and cxgbit by adding common function definitions in libcxgb.
> 
> Is that bunch of misc functionalities or you can provide a more high
> level description what
> you are cleaning out. Also, what other areas are you planning to
> refactor following the review
> comments we had on the target driver?

This patch series removes duplicate function definitions
that are used in connection management.
I am looking into more improvements in connection management,
will post next series once it is ready. 

Thanks
Varun

Re: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

2016-09-14 Thread Or Gerlitz 
On Tue, Sep 13, 2016 at 6:53 PM, Varun Prakash  wrote:
> This patch series removes duplicate code from
> iw_cxgb4 and cxgbit by adding common function definitions in libcxgb.

Is that bunch of misc functionalities or you can provide a more high
level description what
you are cleaning out. Also, what other areas are you planning to
refactor following the review
comments we had on the target driver?

Or.

RE: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

2016-09-13 Thread Steve Wise 
> This patch series removes duplicate code from
> iw_cxgb4 and cxgbit by adding common function
> definitions in libcxgb.
> 
> Please review.
> 
> Thanks
> Varun
> 
> Varun Prakash (11):
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_get_4tuple()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route6()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_is_neg_adv()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_best_mtu()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_compute_wscale()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_tid_release()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_close_con_req()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_req()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_rpl()
>   libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_rx_data_ack()
> 
>  drivers/infiniband/hw/cxgb4/Kconfig   |   1 +
>  drivers/infiniband/hw/cxgb4/Makefile  |   1 +
>  drivers/infiniband/hw/cxgb4/cm.c  | 288
++
>  drivers/infiniband/hw/cxgb4/iw_cxgb4.h|   9 -
>  drivers/net/ethernet/chelsio/libcxgb/Makefile |   4 +-
>  drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c | 149 +++
>  drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 160 
>  drivers/target/iscsi/cxgbit/cxgbit_cm.c   | 234 +++---
>  8 files changed, 428 insertions(+), 418 deletions(-)
>  create mode 100644 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c
>  create mode 100644 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h
> 

This series looks good.

Reviewed-by: Steve Wise 

Thanks Varun!

Steve

[net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

2016-09-13 Thread Varun Prakash 
This patch series removes duplicate code from
iw_cxgb4 and cxgbit by adding common function
definitions in libcxgb.

Please review.

Thanks
Varun

Varun Prakash (11):
  libcxgb,iw_cxgb4,cxgbit: add cxgb_get_4tuple()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route6()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_is_neg_adv()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_best_mtu()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_compute_wscale()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_tid_release()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_close_con_req()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_req()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_rpl()
  libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_rx_data_ack()

 drivers/infiniband/hw/cxgb4/Kconfig   |   1 +
 drivers/infiniband/hw/cxgb4/Makefile  |   1 +
 drivers/infiniband/hw/cxgb4/cm.c  | 288 ++
 drivers/infiniband/hw/cxgb4/iw_cxgb4.h|   9 -
 drivers/net/ethernet/chelsio/libcxgb/Makefile |   4 +-
 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c | 149 +++
 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 160 
 drivers/target/iscsi/cxgbit/cxgbit_cm.c   | 234 +++---
 8 files changed, 428 insertions(+), 418 deletions(-)
 create mode 100644 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c
 create mode 100644 drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h

-- 
2.0.2