Re: [patch 3/5] ATM: he: fix section mismatch

[Roland Dreier]

  WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from 
  .text between 'he_start' (at offset 0x218a) and 'he_service_tbrq'

  -static int __init
  +static int __devinit
   he_init_group(struct he_dev *he_dev, int group)

There are a ton of other __init functions (he_init_irq(),
he_init_tx_lbfp(), etc.) called from the __devinit function he_start()
in this driver.  So I think this patch is insufficient -- does it even
really fix the warning??  (I think -funit-at-a-time hides the warning
with this patch on x86-64)

Anyway, I sent a more comprehensive fix to Chas who forwarded it to
DaveM already.

 - R.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch 3/5] ATM: he: fix section mismatch

[akpm]

From: Randy Dunlap [EMAIL PROTECTED]

WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from 
.text between 'he_start' (at offset 0x218a) and 'he_service_tbrq'

Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---

 drivers/atm/he.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/atm/he.c~atm-he-fix-section-mismatch drivers/atm/he.c
--- a/drivers/atm/he.c~atm-he-fix-section-mismatch
+++ a/drivers/atm/he.c
@@ -785,7 +785,7 @@ he_init_cs_block_rcm(struct he_dev *he_d
return 0;
 }
 
-static int __init
+static int __devinit
 he_init_group(struct he_dev *he_dev, int group)
 {
int i;
_
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html