Re: [patch 5/6] ipv6 - make af_inet6 to check ip6_route_init return value

2007-12-07 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED]
Date: Thu, 06 Dec 2007 14:53:34 +0100

 The af_inet6 initialization function does not check the return code
 of the route initilization, so if something goes wrong, the protocol
 initialization will continue anyway.
 This patch takes into account the modification made in the different
 route's initialization subroutines to check the return value and to 
 make the protocol initialization to fail.
 
 Signed-off-by: Daniel Lezcano [EMAIL PROTECTED]
 Acked-by: Benjamin Thery [EMAIL PROTECTED]

Applied, thanks!
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[patch 5/6] ipv6 - make af_inet6 to check ip6_route_init return value

2007-12-06 Thread Daniel Lezcano
The af_inet6 initialization function does not check the return code
of the route initilization, so if something goes wrong, the protocol
initialization will continue anyway.
This patch takes into account the modification made in the different
route's initialization subroutines to check the return value and to 
make the protocol initialization to fail.

Signed-off-by: Daniel Lezcano [EMAIL PROTECTED]
Acked-by: Benjamin Thery [EMAIL PROTECTED]
---
 net/ipv6/af_inet6.c |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

Index: net-2.6.25/net/ipv6/af_inet6.c
===
--- net-2.6.25.orig/net/ipv6/af_inet6.c
+++ net-2.6.25/net/ipv6/af_inet6.c
@@ -849,7 +849,9 @@ static int __init inet6_init(void)
if (if6_proc_init())
goto proc_if6_fail;
 #endif
-   ip6_route_init();
+   err = ip6_route_init();
+   if (err)
+   goto ip6_route_fail;
ip6_flowlabel_init();
err = addrconf_init();
if (err)
@@ -874,6 +876,7 @@ out:
 addrconf_fail:
ip6_flowlabel_cleanup();
ip6_route_cleanup();
+ip6_route_fail:
 #ifdef CONFIG_PROC_FS
if6_proc_exit();
 proc_if6_fail:
@@ -904,6 +907,7 @@ icmp_fail:
cleanup_ipv6_mibs();
 out_unregister_sock:
sock_unregister(PF_INET6);
+   rtnl_unregister_all(PF_INET6);
 out_unregister_raw_proto:
proto_unregister(rawv6_prot);
 out_unregister_udplite_proto:

-- 
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html