Re: [patch 7/9] 8139cp.c printk fix

[Andrew Morton]

On Fri, 07 Jul 2006 03:38:21 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:

> [EMAIL PROTECTED] wrote:
> > From: Andrew Morton <[EMAIL PROTECTED]>
> > 
> > drivers/net/8139cp.c: In function 'cp_init_one':
> > drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long 
> > unsigned int', but argument 4 has type 'resource_size_t'
> > drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long 
> > unsigned int', but argument 5 has type 'resource_size_t'
> > 
> > 
> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> > ---
> > 
> >  drivers/net/8139cp.c |2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff -puN drivers/net/8139cp.c~8139cp-printk-fix drivers/net/8139cp.c
> > --- a/drivers/net/8139cp.c~8139cp-printk-fix
> > +++ a/drivers/net/8139cp.c
> > @@ -1916,7 +1916,7 @@ static int cp_init_one (struct pci_dev *
> > regs = ioremap(pciaddr, CP_REGS_SIZE);
> > if (!regs) {
> > rc = -EIO;
> > -   dev_err(&pdev->dev, "Cannot map PCI MMIO ([EMAIL PROTECTED])\n",
> > +   dev_err(&pdev->dev, "Cannot map PCI MMIO ([EMAIL PROTECTED])\n",
> >(unsigned long long)pci_resource_len(pdev, 1),
> >(unsigned long long)pciaddr);
> 
> should be %llx if I'm not mistaken...  (looks like a merge screwup on my 
> part)

%llx == %Lx (doesn't it?)

It saves a byte ;)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 7/9] 8139cp.c printk fix

[Jeff Garzik]

[EMAIL PROTECTED] wrote:

From: Andrew Morton <[EMAIL PROTECTED]>

drivers/net/8139cp.c: In function 'cp_init_one':
drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned 
int', but argument 4 has type 'resource_size_t'
drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned 
int', but argument 5 has type 'resource_size_t'


Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/8139cp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/8139cp.c~8139cp-printk-fix drivers/net/8139cp.c
--- a/drivers/net/8139cp.c~8139cp-printk-fix
+++ a/drivers/net/8139cp.c
@@ -1916,7 +1916,7 @@ static int cp_init_one (struct pci_dev *
regs = ioremap(pciaddr, CP_REGS_SIZE);
if (!regs) {
rc = -EIO;
-   dev_err(&pdev->dev, "Cannot map PCI MMIO ([EMAIL PROTECTED])\n",
+   dev_err(&pdev->dev, "Cannot map PCI MMIO ([EMAIL PROTECTED])\n",
   (unsigned long long)pci_resource_len(pdev, 1),
   (unsigned long long)pciaddr);


should be %llx if I'm not mistaken...  (looks like a merge screwup on my 
part)



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch 7/9] 8139cp.c printk fix

[akpm]

From: Andrew Morton <[EMAIL PROTECTED]>

drivers/net/8139cp.c: In function 'cp_init_one':
drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned 
int', but argument 4 has type 'resource_size_t'
drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned 
int', but argument 5 has type 'resource_size_t'


Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/8139cp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/8139cp.c~8139cp-printk-fix drivers/net/8139cp.c
--- a/drivers/net/8139cp.c~8139cp-printk-fix
+++ a/drivers/net/8139cp.c
@@ -1916,7 +1916,7 @@ static int cp_init_one (struct pci_dev *
regs = ioremap(pciaddr, CP_REGS_SIZE);
if (!regs) {
rc = -EIO;
-   dev_err(&pdev->dev, "Cannot map PCI MMIO ([EMAIL PROTECTED])\n",
+   dev_err(&pdev->dev, "Cannot map PCI MMIO ([EMAIL PROTECTED])\n",
   (unsigned long long)pci_resource_len(pdev, 1),
   (unsigned long long)pciaddr);
goto err_out_res;
_
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html