Re: [patch net] rtnetlink: Add rtnexthop offload flag to compare mask

2016-10-19 Thread David Miller 
From: Jiri Pirko 
Date: Tue, 18 Oct 2016 18:59:34 +0200

> From: Jiri Pirko 
> 
> The offload flag is a status flag and should not be used by
> FIB semantics for comparison.
> 
> Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
> Signed-off-by: Jiri Pirko 

Ouch, good catch.

Applied and queued up for -stable, thanks!

Re: [patch net] rtnetlink: Add rtnexthop offload flag to compare mask

2016-10-18 Thread Andy Gospodarek 
On Tue, Oct 18, 2016 at 12:59 PM, Jiri Pirko  wrote:
> From: Jiri Pirko 
>
> The offload flag is a status flag and should not be used by
> FIB semantics for comparison.

This is definitely needed.

>
> Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
> Signed-off-by: Jiri Pirko 
Reviewed-by: Andy Gospodarek 

> ---
> Please queue-up to stable as well. Thanks.
> ---
>  include/uapi/linux/rtnetlink.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> index 262f037..5a78be5 100644
> --- a/include/uapi/linux/rtnetlink.h
> +++ b/include/uapi/linux/rtnetlink.h
> @@ -350,7 +350,7 @@ struct rtnexthop {
>  #define RTNH_F_OFFLOAD 8   /* offloaded route */
>  #define RTNH_F_LINKDOWN16  /* carrier-down on nexthop */
>
> -#define RTNH_COMPARE_MASK  (RTNH_F_DEAD | RTNH_F_LINKDOWN)
> +#define RTNH_COMPARE_MASK  (RTNH_F_DEAD | RTNH_F_LINKDOWN | 
> RTNH_F_OFFLOAD)
>
>  /* Macros to handle hexthops */
>
> --
> 2.5.5
>

[patch net] rtnetlink: Add rtnexthop offload flag to compare mask

2016-10-18 Thread Jiri Pirko 
From: Jiri Pirko 

The offload flag is a status flag and should not be used by
FIB semantics for comparison.

Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
Signed-off-by: Jiri Pirko 
---
Please queue-up to stable as well. Thanks.
---
 include/uapi/linux/rtnetlink.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
index 262f037..5a78be5 100644
--- a/include/uapi/linux/rtnetlink.h
+++ b/include/uapi/linux/rtnetlink.h
@@ -350,7 +350,7 @@ struct rtnexthop {
 #define RTNH_F_OFFLOAD 8   /* offloaded route */
 #define RTNH_F_LINKDOWN16  /* carrier-down on nexthop */
 
-#define RTNH_COMPARE_MASK  (RTNH_F_DEAD | RTNH_F_LINKDOWN)
+#define RTNH_COMPARE_MASK  (RTNH_F_DEAD | RTNH_F_LINKDOWN | RTNH_F_OFFLOAD)
 
 /* Macros to handle hexthops */
 
-- 
2.5.5