RE: A Regression between v4.2-rc2 and v4.2-rc3
From: Peter Chen peter.c...@freescale.com Sent: Wednesday, July 22, 2015 1:45 PM To: netdev@vger.kernel.org Cc: Andrew Lunn; Duan Fugang-B38611; David S. Miller Subject: A Regression between v4.2-rc2 and v4.2-rc3 Hi List, I run out a kernel oops [2] for nfsroot at several imx6 boards when rebase to v4.2-rc3, after revert below patch [1], it is ok. This patch is just adding runtime pm for ipg clock, I am wonder why it takes as a bug fix. [1] commit 6c3e921b18edca290099adfddde8a50236bf2d80 Author: Andrew Lunn and...@lunn.ch Date: Mon Jul 6 20:34:55 2015 +0200 net: fec: Ensure clocks are enabled while using mdio bus When a switch is attached to the mdio bus, the mdio bus can be used while the interface is not open. If the IPG clock is not enabled, MDIO reads/writes will simply time out. Add support for runtime PM to control this clock. Enable/disable this clock using runtime PM, with open()/close() and mdio read()/write() function triggering runtime PM operations. Since PM is optional, the IPG clock is enabled at probe and is no longer modified by fec_enet_clk_enable(), thus if PM is not enabled in the kernel, it is guaranteed the clock is running when MDIO operations are performed. Signed-off-by: Andrew Lunn and...@lunn.ch Acked-by: Fugang Duan b38...@freescale.com Signed-off-by: David S. Miller da...@davemloft.net The patch was reverted in last week. Regards, Andy -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
A Regression between v4.2-rc2 and v4.2-rc3
Hi List, I run out a kernel oops [2] for nfsroot at several imx6 boards when rebase to v4.2-rc3, after revert below patch [1], it is ok. This patch is just adding runtime pm for ipg clock, I am wonder why it takes as a bug fix. [1] commit 6c3e921b18edca290099adfddde8a50236bf2d80 Author: Andrew Lunn and...@lunn.ch Date: Mon Jul 6 20:34:55 2015 +0200 net: fec: Ensure clocks are enabled while using mdio bus When a switch is attached to the mdio bus, the mdio bus can be used while the interface is not open. If the IPG clock is not enabled, MDIO reads/writes will simply time out. Add support for runtime PM to control this clock. Enable/disable this clock using runtime PM, with open()/close() and mdio read()/write() function triggering runtime PM operations. Since PM is optional, the IPG clock is enabled at probe and is no longer modified by fec_enet_clk_enable(), thus if PM is not enabled in the kernel, it is guaranteed the clock is running when MDIO operations are performed. Signed-off-by: Andrew Lunn and...@lunn.ch Acked-by: Fugang Duan b38...@freescale.com Signed-off-by: David S. Miller da...@davemloft.net [2] [2.534260] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.2.0-rc3 #387 [2.540618] Hardware name: Freescale i.MX6 SoloX (Device Tree) [2.546455] Backtrace: [2.548933] [80014e00] (dump_backtrace) from [80015048] (show_stack+0x20/0x24) [2.556506] r6:80cd9db0 r5: r4: r3: [2.562234] [80015028] (show_stack) from [808b0094] (dump_stack+0x8c/0xa4) [2.569467] [808b0008] (dump_stack) from [80077b58] (__lock_acquire+0x1d24/0x1ecc) [2.577385] r6: r5: r4:80e7d900 r3:0001 [2.583107] [80075e34] (__lock_acquire) from [80078608] (lock_acquire+0xa4/0x124) [2.590937] r10:6193 r9:80d3e5c0 r8: r7: r6: r5:be0bdae0 [2.598839] r4: [2.601400] [80078564] (lock_acquire) from [80095870] (call_timer_fn+0x78/0x1a0) [2.609144] r10:0001 r9:0020 r8:bd8cd830 r7:0100 r6:80d3e610 r5:be0bdae0 [2.617045] r4:bd8cd854 [2.619600] [800957f8] (call_timer_fn) from [80095a84] (run_timer_softirq+0xec/0x2a4) [2.62] r10:bd8cd854 r9:0020 r8:bd8cd830 r7:0020 r6:80d3e610 r5:00c9 [2.635679] r4:be7be440 [2.638238] [80095998] (run_timer_softirq) from [80033cbc] (__do_softirq+0xdc/0x364) [2.646329] r10:0100 r9:0004 r8:0001 r7:80d3e32c r6:0202 r5:0001 [2.654230] r4:80c92084 [2.656785] [80033be0] (__do_softirq) from [800342b4] (irq_exit+0xcc/0x140) [2.664094] r10:0001 r9:be01e000 r8:0001 r7: r6:80c932d4 r5: [2.671995] r4:80c8d654 [2.674549] [800341e8] (irq_exit) from [80084254] (__handle_domain_irq+0x7c/0xf0) [2.682380] r4:80c8d654 r3:0125 [2.685990] [800841d8] (__handle_domain_irq) from [800095a8] (gic_handle_irq+0x30/0x70) [2.694342] r9: r8:07c1 r7:c080e100 r6:80c934bc r5:c080e10c r4:be0bdc18 [2.702163] [80009578] (gic_handle_irq) from [80015c24] (__irq_svc+0x44/0x5c) [2.709647] Exception stack(0xbe0bdc18 to 0xbe0bdc60) [2.714702] dc00: 0001 be1103f8 [2.722887] dc20: 6193 2113 80cda1a4 2113 2113 07c1 [2.731068] dc40: 0001 be0bdc74 80e8ecc0 be0bdc60 800758d8 808ba154 2113 [2.739245] r7:be0bdc4c r6: r5:2113 r4:808ba154 [2.744976] [808ba110] (_raw_spin_unlock_irqrestore) from [80385dd0] (add_dma_entry+0xa4/0x164) [2.754023] r5:02f4f305 r4: [2.757633] [80385d2c] (add_dma_entry) from [803861e0] (debug_dma_map_page+0x108/0x120) [2.765984] r7:be1e4010 r6:bef98980 r5:bd3cc140 r4:be280c00 [2.771714] [803860d8] (debug_dma_map_page) from [8051b604] (fec_enet_new_rxbdp.isra.36+0xe4/0x148) [2.781107] r10:be1e4010 r9:0002 r8:bd8c9000 r7:bd3cc140 r6:007a7980 r5:07c1 [2.789008] r4:0140 r3:07c1 [2.792619] [8051b520] (fec_enet_new_rxbdp.isra.36) from [8051c558] (fec_enet_open+0x98/0x570) [2.801578] r10:bd8cc0f0 r9:003c r8:bd8c9640 r7:bd8cc000 r6:bd254480 r5:bd8c9000 [2.809481] r4:bf088780 [2.812043] [8051c4c0] (fec_enet_open) from [806873a4] (__dev_open+0xb8/0x120) [2.819613] r10:80d20f00 r9:bd8c9000 r8: r7:bd8c9030 r6:809194c4 r5: [2.827515] r4:bd8c9000 [2.830069] [806872ec] (__dev_open) from [80687680] (__dev_change_flags+0x98/0x158) [2.838073] r7:1002 r6:1003 r5:0001 r4:bd8c9000 [2.843797] [806875e8] (__dev_change_flags) from [80687768] (dev_change_flags+0x28/0x58) [2.852235] r8: r7:80d20ff0 r6:1002 r5:bd8c9138 r4:bd8c9000 r3:80c678b4 [2.860060] [80687740] (dev_change_flags) from [80c43ed8] (ip_auto_config.part.14+0x184/0x1020) [2.869106] r8:80d20f00 r7:80d20ff0 r6:80d20ff0 r5:1002
