RE: [Intel-wired-lan] Issue with driver i40e stat strings count mismatch

2018-07-31 Thread Keller, Jacob E


> -Original Message-
> From: Wyborny, Carolyn
> Sent: Tuesday, July 31, 2018 8:53 AM
> To: Jesper Dangaard Brouer ; Stefan Assmann
> ; Keller, Jacob E 
> Cc: netdev@vger.kernel.org; intel-wired-lan 
> ;
> Topel, Bjorn ; Keller, Jacob E
> 
> Subject: RE: [Intel-wired-lan] Issue with driver i40e stat strings count 
> mismatch
> 
> > -Original Message-
> > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> > Behalf Of Jesper Dangaard Brouer
> > Sent: Tuesday, July 31, 2018 7:29 AM
> > To: Stefan Assmann ; Keller, Jacob E
> > 
> > Cc: netdev@vger.kernel.org; intel-wired-lan  > l...@lists.osuosl.org>; bro...@redhat.com; Topel, Bjorn
> > 
> > Subject: Re: [Intel-wired-lan] Issue with driver i40e stat strings count
> > mismatch
> >
> >
> > On Tue, 31 Jul 2018 09:05:40 +0200 Stefan Assmann
> >  wrote:
> >
> > > From: Stefan Assmann 
> > > To: Jesper Dangaard Brouer ,  Jeff Kirsher
> > 
> > > Cc: Björn Töpel ,
> > "alexander.h.du...@intel.com" ,  intel-
> > wired-lan ,  "netdev@vger.kernel.org"
> > 
> > > Subject: Re: Issue with driver i40e stat strings count mismatch
> > > Date: Tue, 31 Jul 2018 09:05:40 +0200
> > > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
> > >  Thunderbird/52.9.1
> > > Message-ID: <64be8e6a-c285-2864-fd91-356eba645...@kpanic.de>
> > >
> > > On 10.07.2018 13:17, Jesper Dangaard Brouer wrote:
> > > > Hi Intel-fokes,
> > > >
> > > > Your i40e driver have issues with it's ethtool stats.  A warning
> > > > triggers at drivers/net/ethernet/intel/i40e/i40e_ethtool.c line 1907
> > > > (see splash below) in func i40e_get_stat_strings().
> > >
> > > Hi Jesper,
> > >
> > > I ran into the same issue. Here's my proposed fix.
> >
> > Thanks for following up Stefan :-)
> >
> > I'm hoping some Intel people will look at evaluating this fix? ...
> >
> Thanks, we have a patch in process for this fix and other related ones from 
> Jake
> Keller.  We'll expedite it.
> 
> Carolyn
> 
> Carolyn Wyborny
> Linux Development
> Networking Division
> Intel Corporation
> 
> 

Yea I found tihs issue a while ago and we had a patch internally. I suspect it 
just got lost in a shuffle earlier

I think we have an equivalent patch, but I don't care which gets applied.

Thanks,
Jake


RE: [Intel-wired-lan] Issue with driver i40e stat strings count mismatch

2018-07-31 Thread Wyborny, Carolyn
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Jesper Dangaard Brouer
> Sent: Tuesday, July 31, 2018 7:29 AM
> To: Stefan Assmann ; Keller, Jacob E
> 
> Cc: netdev@vger.kernel.org; intel-wired-lan  l...@lists.osuosl.org>; bro...@redhat.com; Topel, Bjorn
> 
> Subject: Re: [Intel-wired-lan] Issue with driver i40e stat strings count
> mismatch
> 
> 
> On Tue, 31 Jul 2018 09:05:40 +0200 Stefan Assmann
>  wrote:
> 
> > From: Stefan Assmann 
> > To: Jesper Dangaard Brouer ,  Jeff Kirsher
> 
> > Cc: Björn Töpel ,
> "alexander.h.du...@intel.com" ,  intel-
> wired-lan ,  "netdev@vger.kernel.org"
> 
> > Subject: Re: Issue with driver i40e stat strings count mismatch
> > Date: Tue, 31 Jul 2018 09:05:40 +0200
> > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
> >  Thunderbird/52.9.1
> > Message-ID: <64be8e6a-c285-2864-fd91-356eba645...@kpanic.de>
> >
> > On 10.07.2018 13:17, Jesper Dangaard Brouer wrote:
> > > Hi Intel-fokes,
> > >
> > > Your i40e driver have issues with it's ethtool stats.  A warning
> > > triggers at drivers/net/ethernet/intel/i40e/i40e_ethtool.c line 1907
> > > (see splash below) in func i40e_get_stat_strings().
> >
> > Hi Jesper,
> >
> > I ran into the same issue. Here's my proposed fix.
> 
> Thanks for following up Stefan :-)
> 
> I'm hoping some Intel people will look at evaluating this fix? ...
> 
Thanks, we have a patch in process for this fix and other related ones from 
Jake Keller.  We'll expedite it.

Carolyn

Carolyn Wyborny 
Linux Development 
Networking Division 
Intel Corporation