Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
From: Denys Vlasenko Date: Mon, 19 Jun 2017 21:50:52 +0200 > Only compile-tested - I don't have the hardware. > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > anyway. > > Signed-off-by: Denys Vlasenko Applied to net-next, thanks.
Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
From: David Miller Date: Tue, 20 Jun 2017 21:17:13 -0400 > From: Felix Manlunas > Date: Tue, 20 Jun 2017 13:51:25 -0700 > > > From: Derek Chickles > > Date: Tue, 20 Jun 2017 13:15:34 -0700 > > > >> > From: David Miller [mailto:da...@davemloft.net] > >> > Sent: Tuesday, June 20, 2017 12:22 PM > >> > > >> > From: Denys Vlasenko > >> > Date: Mon, 19 Jun 2017 21:50:52 +0200 > >> > > >> > > Only compile-tested - I don't have the hardware. > >> > > > >> > > From code inspection, octeon_pci_write_core_mem() appears to be safe > >> > > wrt > >> > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be > >> > > aligned > >> > > anyway. > >> > > > >> > > Signed-off-by: Denys Vlasenko > >> > > >> > Looks good to me but I'll let one of the liquidio guys review this first > >> > before I apply it. > >> > >> Felix is going to try this out this week to confirm. Let's wait for his > >> ack. > > > > This patch works. I tested it with a LiquidIO II adapter. > > > > ACK > > Please ACK patches in the standard way which is in the form of: > > Acked-by: David S. Miller > > This tag is recognized by tools and in particular the patchwork > site where networking patches are maintained, automatically > including your ACK into the patch I apply. Acked-by: Felix Manlunas
Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
From: Felix Manlunas Date: Tue, 20 Jun 2017 13:51:25 -0700 > From: Derek Chickles > Date: Tue, 20 Jun 2017 13:15:34 -0700 > >> > From: David Miller [mailto:da...@davemloft.net] >> > Sent: Tuesday, June 20, 2017 12:22 PM >> > >> > From: Denys Vlasenko >> > Date: Mon, 19 Jun 2017 21:50:52 +0200 >> > >> > > Only compile-tested - I don't have the hardware. >> > > >> > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt >> > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned >> > > anyway. >> > > >> > > Signed-off-by: Denys Vlasenko >> > >> > Looks good to me but I'll let one of the liquidio guys review this first >> > before I apply it. >> >> Felix is going to try this out this week to confirm. Let's wait for his ack. > > This patch works. I tested it with a LiquidIO II adapter. > > ACK Please ACK patches in the standard way which is in the form of: Acked-by: David S. Miller This tag is recognized by tools and in particular the patchwork site where networking patches are maintained, automatically including your ACK into the patch I apply.
Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
From: Derek Chickles Date: Tue, 20 Jun 2017 13:15:34 -0700 > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Tuesday, June 20, 2017 12:22 PM > > > > From: Denys Vlasenko > > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > > > Only compile-tested - I don't have the hardware. > > > > > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > > > anyway. > > > > > > Signed-off-by: Denys Vlasenko > > > > Looks good to me but I'll let one of the liquidio guys review this first > > before I apply it. > > Felix is going to try this out this week to confirm. Let's wait for his ack. This patch works. I tested it with a LiquidIO II adapter. ACK
RE: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
> From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 20, 2017 12:22 PM > > From: Denys Vlasenko > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > Only compile-tested - I don't have the hardware. > > > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > > anyway. > > > > Signed-off-by: Denys Vlasenko > > Looks good to me but I'll let one of the liquidio guys review this first > before I apply it. Felix is going to try this out this week to confirm. Let's wait for his ack.
Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
From: Denys Vlasenko Date: Mon, 19 Jun 2017 21:50:52 +0200 > Only compile-tested - I don't have the hardware. > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > anyway. > > Signed-off-by: Denys Vlasenko Looks good to me but I'll let one of the liquidio guys review this first before I apply it.
