Re: [PATCH 10/14 v2] nes: eeprom and phy routines

[Roland Dreier]

  +/* TODO: deal with EEPROM endian issues */

This is pretty scary.  Is the driver broken on big-endian systems now?

  +/*
  +Everything you wanted to know about CRC algorithms, but were afraid to ask
  + for fear that errors in your understanding might be detected. Version  : 
  3.

etc etc... can all this be replaced with what's in lib/crc32.c?  (I
hope so)

 - R.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 10/14 v2] nes: eeprom and phy routines

[Glenn Grundstrom]

   +/*
   +Everything you wanted to know about CRC algorithms, but 
 were afraid to ask
   + for fear that errors in your understanding might be 
 detected. Version  : 3.
 
 etc etc... can all this be replaced with what's in lib/crc32.c?  (I
 hope so)

Replacing this code is already in the works.

Glenn.

 
  - R.
 
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html