Re: [PATCH] net-next: ethtool: Added port speed macros.
From: David Miller Date: Tue, 19 May 2015 14:52:02 -0400 (EDT) > Given that I should probably accept this patch set as well, hopefully > we won't get very many more of these any time soon. And that's what I've just done. Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net-next: ethtool: Added port speed macros.
From: Ben Hutchings Date: Tue, 19 May 2015 18:00:35 +0100 > On Mon, 2015-05-18 at 11:46 -0400, David Miller wrote: >> From: Parav Pandit >> Date: Mon, 18 May 2015 16:31:47 +0530 >> >> > Signed-off-by: Parav Pandit >> >> I thought we had decided that we weren't going to keep adding >> convenience macros for new speeds, and were simply going to use >> the appropriate constants in the future. >> >> Ben? > > That's what I thought, but you accepted commit dcf972a334dd "ethtool, > net/mlx4_en: Add 100M, 20G, 56G speeds ethtool reporting support" not so > long ago. Grumble... my bad. Given that I should probably accept this patch set as well, hopefully we won't get very many more of these any time soon. Sorry for creating this mess. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net-next: ethtool: Added port speed macros.
From: Parav Pandit Date: Tue, 19 May 2015 10:15:49 +0530 > On Mon, May 18, 2015 at 9:16 PM, David Miller wrote: >> From: Parav Pandit >> Date: Mon, 18 May 2015 16:31:47 +0530 >> >>> Signed-off-by: Parav Pandit >> >> I thought we had decided that we weren't going to keep adding >> convenience macros for new speeds, and were simply going to use >> the appropriate constants in the future. >> > > I added them to accommodate any speed/PHY interface specific > configuration to make use of it. > If convenience macros are not needed, I will provide the code cleanup > patch to remove existing convenience macros. With that we will have > unified code for old and new constants. > I will anyway let Ben comment on it. You cannot remove the existing macros, because they are exported to userspace and you'll break application compilation if you do that. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net-next: ethtool: Added port speed macros.
From: Parav Pandit Date: Mon, 18 May 2015 16:31:47 +0530 > Signed-off-by: Parav Pandit I thought we had decided that we weren't going to keep adding convenience macros for new speeds, and were simply going to use the appropriate constants in the future. Ben? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
