Re: [PATCH] tcp: turn ABC off

2006-09-02 Thread Evgeniy Polyakov
On Fri, Sep 01, 2006 at 01:55:15PM -0700, Stephen Hemminger ([EMAIL PROTECTED]) 
wrote:
 diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
 index 111ff39..159fa3f 100644
 --- a/net/ipv4/tcp_input.c
 +++ b/net/ipv4/tcp_input.c
 @@ -89,7 +89,7 @@ int sysctl_tcp_frto;
  int sysctl_tcp_nometrics_save;
  
  int sysctl_tcp_moderate_rcvbuf = 1;
 -int sysctl_tcp_abc = 1;
 +int sysctl_tcp_abc;

Since it is not static are you sure it will be zero?

-- 
Evgeniy Polyakov

-- 
VGER BF report: H 8.21099e-10
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] tcp: turn ABC off

2006-09-02 Thread Herbert Xu
Evgeniy Polyakov [EMAIL PROTECTED] wrote:
 On Fri, Sep 01, 2006 at 01:55:15PM -0700, Stephen Hemminger ([EMAIL 
 PROTECTED]) wrote:
 diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
 index 111ff39..159fa3f 100644
 --- a/net/ipv4/tcp_input.c
 +++ b/net/ipv4/tcp_input.c
 @@ -89,7 +89,7 @@ int sysctl_tcp_frto;
  int sysctl_tcp_nometrics_save;
  
  int sysctl_tcp_moderate_rcvbuf = 1;
 -int sysctl_tcp_abc = 1;
 +int sysctl_tcp_abc;
 
 Since it is not static are you sure it will be zero?

Outside a function the static modifier merely modifies whether the
symbol is visible externally.  It does not control whether it gets
zeroed.  And yes this will get zeroed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

-- 
VGER BF report: U 0.49998
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html