Re: [PATCH 00/04] smc91x: request bus width using platform data

2008-02-20 Thread Nicolas Pitre
On Wed, 20 Feb 2008, Magnus Damm wrote:

 These patches make it possible to request bus width in the platform data.
 
 Instead of keep on updating smc91x.h with board specific configuration,
 use platform data to pass along bus width and irq flags to the driver.
 This change is designed to be backwards-compatible, so all boards configured
 in the header file should just work as usual.

Thank you for doing this work.  I really meant to do it, and commit 
09779c6df2dbe95483269d194b327d41fe2cc57e was the first step towards that 
goal, but as you can see we're nearly two years later and I didn't do 
it.

I have a few comments though.  I will reply to those messages 
separately.


Nicolas
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 00/04] smc91x: request bus width using platform data

2008-02-20 Thread Magnus Damm
On Thu, Feb 21, 2008 at 12:36 AM, Nicolas Pitre [EMAIL PROTECTED] wrote:
 On Wed, 20 Feb 2008, Magnus Damm wrote:

   These patches make it possible to request bus width in the platform data.
  
   Instead of keep on updating smc91x.h with board specific configuration,
   use platform data to pass along bus width and irq flags to the driver.
   This change is designed to be backwards-compatible, so all boards 
 configured
   in the header file should just work as usual.

  Thank you for doing this work.  I really meant to do it, and commit
  09779c6df2dbe95483269d194b327d41fe2cc57e was the first step towards that
  goal, but as you can see we're nearly two years later and I didn't do
  it.

It's only a lot of boring search and replace work so I don't blame you
for not doing it. =) I'm glad that you like the idea of keeping bus
width flags with the platform data. Hopefully this will make it easier
to support smc91x on a wide range of boards.

  I have a few comments though.  I will reply to those messages
  separately.

Great, thanks. Please let me know which way you think is the best and
I'll rework the patches and repost.

Cheers,

/ magnus
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html