Re: [PATCH 2/2] net: rfkill: Add rfkill-any LED trigger
> Thanks, these are obviously all valid concerns. Sorry for being > sloppy > with the ifdefs. If I get positive feedback on the proposed feature > itself, all these issues (and the warning pointed out in the other > message) will be resolved in v2. Looks fine, please do that. johannes
Re: [PATCH 2/2] net: rfkill: Add rfkill-any LED trigger
> Hi Michał, > > [auto build test ERROR on mac80211-next/master] > [also build test ERROR on v4.9-rc7 next-20161201] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Micha-K-pie/net-rfkill-Cleanup-error-handling-in-rfkill_init/20161202-002119 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master > config: i386-randconfig-x004-201648 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > >net/rfkill/core.c: In function 'rfkill_set_block': > >> net/rfkill/core.c:354:2: error: implicit declaration of function > >> '__rfkill_any_led_trigger_event' [-Werror=implicit-function-declaration] > __rfkill_any_led_trigger_event(); > ^~ >net/rfkill/core.c: In function 'rfkill_init': >net/rfkill/core.c:1349:1: warning: label 'error_led_trigger' defined but > not used [-Wunused-label] > error_led_trigger: > ^ >At top level: >net/rfkill/core.c:243:13: warning: 'rfkill_any_led_trigger_unregister' > defined but not used [-Wunused-function] > static void rfkill_any_led_trigger_unregister(void) > ^ >net/rfkill/core.c:238:12: warning: 'rfkill_any_led_trigger_register' > defined but not used [-Wunused-function] > static int rfkill_any_led_trigger_register(void) >^~~ >cc1: some warnings being treated as errors > > vim +/__rfkill_any_led_trigger_event +354 net/rfkill/core.c > >348rfkill->state &= ~RFKILL_BLOCK_SW_SETCALL; >349rfkill->state &= ~RFKILL_BLOCK_SW_PREV; >350curr = rfkill->state & RFKILL_BLOCK_SW; >351spin_unlock_irqrestore(>lock, flags); >352 >353rfkill_led_trigger_event(rfkill); > > 354__rfkill_any_led_trigger_event(); >355 >356if (prev != curr) >357rfkill_event(rfkill); Thanks, these are obviously all valid concerns. Sorry for being sloppy with the ifdefs. If I get positive feedback on the proposed feature itself, all these issues (and the warning pointed out in the other message) will be resolved in v2. -- Best regards, Michał Kępień
Re: [PATCH 2/2] net: rfkill: Add rfkill-any LED trigger
Hi Michał, [auto build test WARNING on mac80211-next/master] [also build test WARNING on v4.9-rc7 next-20161201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Micha-K-pie/net-rfkill-Cleanup-error-handling-in-rfkill_init/20161202-002119 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: blackfin-allmodconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=blackfin All warnings (new ones prefixed by >>): >> WARNING: net/rfkill/rfkill.o(.init.text+0xa2): Section mismatch in reference >> from the function _init_module() to the function >> .exit.text:_rfkill_handler_exit() The function __init _init_module() references a function __exit _rfkill_handler_exit(). This is often seen when error handling in the init function uses functionality in the exit path. The fix is often to remove the __exit annotation of _rfkill_handler_exit() so it may be used outside an exit section. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 2/2] net: rfkill: Add rfkill-any LED trigger
Hi Michał, [auto build test ERROR on mac80211-next/master] [also build test ERROR on v4.9-rc7 next-20161201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Micha-K-pie/net-rfkill-Cleanup-error-handling-in-rfkill_init/20161202-002119 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: i386-randconfig-x004-201648 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): net/rfkill/core.c: In function 'rfkill_set_block': >> net/rfkill/core.c:354:2: error: implicit declaration of function >> '__rfkill_any_led_trigger_event' [-Werror=implicit-function-declaration] __rfkill_any_led_trigger_event(); ^~ net/rfkill/core.c: In function 'rfkill_init': net/rfkill/core.c:1349:1: warning: label 'error_led_trigger' defined but not used [-Wunused-label] error_led_trigger: ^ At top level: net/rfkill/core.c:243:13: warning: 'rfkill_any_led_trigger_unregister' defined but not used [-Wunused-function] static void rfkill_any_led_trigger_unregister(void) ^ net/rfkill/core.c:238:12: warning: 'rfkill_any_led_trigger_register' defined but not used [-Wunused-function] static int rfkill_any_led_trigger_register(void) ^~~ cc1: some warnings being treated as errors vim +/__rfkill_any_led_trigger_event +354 net/rfkill/core.c 348 rfkill->state &= ~RFKILL_BLOCK_SW_SETCALL; 349 rfkill->state &= ~RFKILL_BLOCK_SW_PREV; 350 curr = rfkill->state & RFKILL_BLOCK_SW; 351 spin_unlock_irqrestore(>lock, flags); 352 353 rfkill_led_trigger_event(rfkill); > 354 __rfkill_any_led_trigger_event(); 355 356 if (prev != curr) 357 rfkill_event(rfkill); --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
