Re: [PATCH V6 8/8] hvsock: introduce Hyper-V Socket feature

2016-01-26 Thread Olaf Hering
On Tue, Jan 26, Dexuan Cui wrote:

> +#define AF_MAX   42  /* For now.. */

Maybe net/core/sock.c needs additional strings for the new socket?

Olaf


RE: [PATCH V6 8/8] hvsock: introduce Hyper-V Socket feature

2016-01-26 Thread Dexuan Cui
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Tuesday, January 26, 2016 18:24
> To: Dexuan Cui <de...@microsoft.com>
> Cc: gre...@linuxfoundation.org; da...@davemloft.net;
> step...@networkplumber.org; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; driverdev-de...@linuxdriverproject.org;
> a...@canonical.com; jasow...@redhat.com; KY Srinivasan
> <k...@microsoft.com>; vkuzn...@redhat.com; pebo...@tiscali.nl;
> stefa...@redhat.com; dan.carpen...@oracle.com
> Subject: Re: [PATCH V6 8/8] hvsock: introduce Hyper-V Socket feature
> 
> On Tue, Jan 26, Dexuan Cui wrote:
> 
> > +#define AF_MAX 42  /* For now.. */
> 
> Maybe net/core/sock.c needs additional strings for the new socket?
> 
> Olaf
Olaf, Thanks for the reminder!

I'll add a new patch like this:

diff --git a/net/core/sock.c b/net/core/sock.c
index 6c1c8bc..3c0aedb 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -221,7 +221,8 @@ static const char *const af_family_key_strings[AF_MAX+1] = {
   "sk_lock-AF_TIPC"  , "sk_lock-AF_BLUETOOTH", "sk_lock-IUCV",
   "sk_lock-AF_RXRPC" , "sk_lock-AF_ISDN" , "sk_lock-AF_PHONET"   ,
   "sk_lock-AF_IEEE802154", "sk_lock-AF_CAIF" , "sk_lock-AF_ALG"  ,
-  "sk_lock-AF_NFC"   , "sk_lock-AF_VSOCK", "sk_lock-AF_MAX"
+  "sk_lock-AF_NFC"   , "sk_lock-AF_VSOCK", "sk_lock-AF_HYPERV"
+  "sk_lock-AF_MAX"
 };
 static const char *const af_family_slock_key_strings[AF_MAX+1] = {
   "slock-AF_UNSPEC", "slock-AF_UNIX" , "slock-AF_INET" ,
@@ -237,7 +238,8 @@ static const char *const 
af_family_slock_key_strings[AF_MAX+1] = {
   "slock-AF_TIPC"  , "slock-AF_BLUETOOTH", "slock-AF_IUCV" ,
   "slock-AF_RXRPC" , "slock-AF_ISDN" , "slock-AF_PHONET"   ,
   "slock-AF_IEEE802154", "slock-AF_CAIF" , "slock-AF_ALG"  ,
-  "slock-AF_NFC"   , "slock-AF_VSOCK","slock-AF_MAX"
+  "slock-AF_NFC"   , "slock-AF_VSOCK","slock-AF_HYPERV"
+  "slock-AF_MAX"
 };
 static const char *const af_family_clock_key_strings[AF_MAX+1] = {
   "clock-AF_UNSPEC", "clock-AF_UNIX" , "clock-AF_INET" ,
@@ -253,7 +255,8 @@ static const char *const 
af_family_clock_key_strings[AF_MAX+1] = {
   "clock-AF_TIPC"  , "clock-AF_BLUETOOTH", "clock-AF_IUCV" ,
   "clock-AF_RXRPC" , "clock-AF_ISDN" , "clock-AF_PHONET"   ,
   "clock-AF_IEEE802154", "clock-AF_CAIF" , "clock-AF_ALG"  ,
-  "clock-AF_NFC"   , "clock-AF_VSOCK", "clock-AF_MAX"
+  "clock-AF_NFC"   , "clock-AF_VSOCK", "clock-AF_HYPERV"
+  "clock-AF_MAX"
 };

 /*

Thanks,
-- Dexuan