Re: [PATCH net-next 2/2 v8] net: ethernet: Add a driver for Gemini gigabit ethernet

[Linus Walleij]

On Mon, Dec 11, 2017 at 8:16 PM, David Miller  wrote:
> From: Linus Walleij 

>> +if NET_VENDOR_CORTINA
>> +
>> +config GEMINI_ETHERNET
>> + tristate "Gemini Gigabit Ethernet support"
>> + depends on ARCH_GEMINI
>> + depends on OF
>> + select PHYLIB
>> + select CRC32
>> + ---help---
>> +   This driver supports StorLink SL351x (Gemini) dual Gigabit Ethernet.
>
> Make this driver buildable anywhere, you don't use any platform architecture
> specific features.

I pushed the recent v9 set where I remove the dep on ARCH_GEMINI
and the autobuilders complain a lot about the use of dma_to_pfn()
which turns out to be a ARM thing from 
included from .

I will try switching to functions from the generic dma-mapping API
and fix it up and send a v10.

Yours,
Linus Walleij

Re: [PATCH net-next 2/2 v8] net: ethernet: Add a driver for Gemini gigabit ethernet

[David Miller]

From: Linus Walleij 
Date: Sun, 10 Dec 2017 23:45:58 +0100

> diff --git a/drivers/net/ethernet/cortina/Kconfig 
> b/drivers/net/ethernet/cortina/Kconfig
> new file mode 100644
> index ..7d279ac4357d
> --- /dev/null
> +++ b/drivers/net/ethernet/cortina/Kconfig
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Cortina ethernet devices
> +
> +config NET_VENDOR_CORTINA
> + bool "Cortina Gemini devices"
> + depends on (ARM || COMPILE_TEST)
> + default ARCH_GEMINI
> + ---help---
> +   If you have a network (Ethernet) card belonging to this class, say Y
> +   and read the Ethernet-HOWTO, available from
> +   .

Vendor Kconfig guards should default to 'y'.  Remove the depends guard.

> +
> +if NET_VENDOR_CORTINA
> +
> +config GEMINI_ETHERNET
> + tristate "Gemini Gigabit Ethernet support"
> + depends on ARCH_GEMINI
> + depends on OF
> + select PHYLIB
> + select CRC32
> + ---help---
> +   This driver supports StorLink SL351x (Gemini) dual Gigabit Ethernet.

Make this driver buildable anywhere, you don't use any platform architecture
specific features.

Otherwise your driver will have bad build coverage and will likely
stop building when core APIs are changed.