Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

[Or Gerlitz]

On Thu, Sep 8, 2016 at 1:36 AM, David Miller  wrote:
> From: Or Gerlitz 
> Date: Wed, 7 Sep 2016 23:51:56 +0300
>
>> On Wed, Sep 7, 2016 at 11:27 PM, David Miller  wrote:
>>> From: Saeed Mahameed 
>>> Date: Wed, 7 Sep 2016 23:16:13 +0300
>>>
 Hi Dave, Sorry to bother, but i would like to drop this series for now
 Huy is working to define and come up with a better mechanism to
 enable/disable the new DCBX hybrid mode he is adding.
>>>
>>> I can't "just drop" any change that's in my tree already.
>>
>> Dave, I don't see it @ your kernel.org clone but it's not in
>> patchworks either, so I guess you picked that into your other clone.
>
> Aha, I marked it "changes requested" in patchwork and did not apply it.
> My bad.

Don't worry, happens...

Thank you

Or.

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

[David Miller]

From: Or Gerlitz 
Date: Wed, 7 Sep 2016 23:51:56 +0300

> On Wed, Sep 7, 2016 at 11:27 PM, David Miller  wrote:
>> From: Saeed Mahameed 
>> Date: Wed, 7 Sep 2016 23:16:13 +0300
>>
>>> Hi Dave, Sorry to bother, but i would like to drop this series for now
>>> Huy is working to define and come up with a better mechanism to
>>> enable/disable the new DCBX hybrid mode he is adding.
>>
>> I can't "just drop" any change that's in my tree already.
> 
> Dave, I don't see it @ your kernel.org clone but it's not in
> patchworks either, so I guess you picked that into your other clone.

Aha, I marked it "changes requested" in patchwork and did not apply
it.

My bad.

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

[Or Gerlitz]

On Wed, Sep 7, 2016 at 11:27 PM, David Miller  wrote:
> From: Saeed Mahameed 
> Date: Wed, 7 Sep 2016 23:16:13 +0300
>
>> Hi Dave, Sorry to bother, but i would like to drop this series for now
>> Huy is working to define and come up with a better mechanism to
>> enable/disable the new DCBX hybrid mode he is adding.
>
> I can't "just drop" any change that's in my tree already.

Dave, I don't see it @ your kernel.org clone but it's not in
patchworks either, so I guess you picked that into your other clone.
If indeed you took it (and I guess this is the case), please note that
was done in spite of a pending reviewer comment
(by me) on the actual necessity of patch #3. If its not possible to
revert them on the non kernel.org clone before you push it to
kernel.org, I guess we need to send you a revert

[1] http://marc.info/?l=linux-netdev=147317917622462=2

> It is part of the permanent GIT record as I never rebase my trees for
> any reason whatsoever.

> So the best you can do is send me a revert patch.

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

[David Miller]

From: Saeed Mahameed 
Date: Wed, 7 Sep 2016 23:16:13 +0300

> Hi Dave, Sorry to bother, but i would like to drop this series for now
> Huy is working to define and come up with a better mechanism to
> enable/disable the new DCBX hybrid mode he is adding.

I can't "just drop" any change that's in my tree already.

It is part of the permanent GIT record as I never rebase my trees for
any reason whatsoever.

So the best you can do is send me a revert patch.

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

[Saeed Mahameed]

On Tue, Sep 6, 2016 at 7:04 PM, Saeed Mahameed  wrote:
> Hi Dave,
>

Hi Dave, Sorry to bother, but i would like to drop this series for now
Huy is working to define and come up with a better mechanism to
enable/disable the new DCBX hybrid mode he is adding.

Thanks for understanding,
Saeed.

> This series from Huy provides mlx5 DCBX updates to support DCBX CEE
> API and DCBX firmware/host modes support.
>
> 1st patch ensures the dcbnl_rtnl_ops is published only when the qos 
> capability bits is on.
>
> 2nd patch adds the support for CEE interfaces into mlx5 dcbnl_rtnl_ops.
>
> 3rd patch refactors ETS query to read ETS configuration directly from 
> firmware rather
> than having a software shadow to it. The existing IEEE interfaces stays the 
> same.
>
> 4th patch adds the support for MLX5_REG_DCBX_PARAM and MLX5_REG_DCBX_APP 
> firmware
> commands to manipulate mlx5 DCBX mode.
>
> 5th patch adds the driver support for the new DCBX firmware.
> This ensures the backward compatibility versus the old and new firmware.
> With the new DCBX firmware, qos settings can be controlled by either firmware
> or software depending on the DCBX mode.
>
> 6th patch adds support for module events log.
>
> Changes since V1:
> 1. Add qos capability check
> 2. In port module events eqe structure, change rsvd_n to reserved_at_n to be 
> consistent with mlx5_ifc.h
> 3. Improve commit messages
> 4. Drop DCBX private flags patch
> 5. Add patch to check for qos capability bit check before exposing dcb 
> interfaces
> 6. Replace memset with static array initialization
>
> Thanks,
> Saeed.
>
> Huy Nguyen (6):
>   net/mlx5e: Add qos capability check
>   net/mlx5e: Support DCBX CEE API
>   net/mlx5e: Read ETS settings directly from firmware
>   net/mlx5: Add DCBX firmware commands support
>   net/mlx5e: ConnectX-4 firmware support for DCBX
>   net/mlx5: Add handling for port module event
>
>  drivers/net/ethernet/mellanox/mlx5/core/en.h   |  36 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 483 
> -
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c  |  27 +-
>  drivers/net/ethernet/mellanox/mlx5/core/eq.c   |  12 +
>  .../net/ethernet/mellanox/mlx5/core/mlx5_core.h|   1 +
>  drivers/net/ethernet/mellanox/mlx5/core/port.c | 148 +++
>  include/linux/mlx5/device.h|  11 +
>  include/linux/mlx5/driver.h|   7 +
>  include/linux/mlx5/mlx5_ifc.h  |   3 +-
>  include/linux/mlx5/port.h  |   6 +
>  10 files changed, 698 insertions(+), 36 deletions(-)
>
> --
> 2.7.4
>