Re: [PATCH net-next v3] mpls: support for dead routes

[kbuild test robot]

Hi Roopa,

[auto build test WARNING on net-next/master]
[also WARNING on: next-20151103]

url:
https://github.com/0day-ci/linux/commits/Roopa-Prabhu/mpls-support-for-dead-routes/20151103-225234
base:   https://github.com/0day-ci/linux 
Roopa-Prabhu/mpls-support-for-dead-routes/20151103-225234


coccinelle warnings: (new ones prefixed by >>)

>> net/mpls/af_mpls.c:722:22-23: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next v3] mpls: support for dead routes

[Robert Shearman]

On 03/11/15 14:49, Roopa Prabhu wrote:

From: Roopa Prabhu 

Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls
routes due to link events. Also adds code to ignore dead
routes during route selection

Signed-off-by: Roopa Prabhu 
---
Dave, I know you are only taking bug fixes currently. This patch
is borderline a bug fix because Eric thinks it is critical for
mpls multipath routes. I can sure resubmit it as a bug fix against net
when it is time if you did prefer that. Thanks!

RFC to v1:
 Addressed a few comments from Eric and Robert:
 - remove support for weighted nexthops
 - Use rt_nhn_alive in the rt structure to keep count of alive
 routes.
 What i have not done is: sort nexthops on link events.
 I am not comfortable recreating or sorting nexthops on
 every carrier change. This leaves scope for optimizing in the future

v1 to v2:
 Fix dead nexthop checks as suggested by dave

v2 to v3:
Fix duplicated argument reported by kbuild test robot


FYI, I've sent out comments to v2 and all but one of them also apply to 
this version too.


Thanks,
Rob
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html