Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

[kbuild test robot]

Hi Subash,

[auto build test ERROR on net-next/master]

url:
https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-Add-sysctl-to-toggle-early-demux-for-tcp-and-udp/20170323-205131
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget 
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   net/built-in.o: In function `proc_tcp_early_demux':
>> ncsi-manage.c:(.text+0xdffd4): undefined reference to 
>> `tcp_v6_early_demux_configure'
   net/built-in.o: In function `proc_udp_early_demux':
>> ncsi-manage.c:(.text+0xe0040): undefined reference to 
>> `udp_v6_early_demux_configure'

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

[kbuild test robot]

Hi Subash,

[auto build test ERROR on net-next/master]

url:
https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-Add-sysctl-to-toggle-early-demux-for-tcp-and-udp/20170323-205131
config: x86_64-kexec (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net/built-in.o: In function `proc_tcp_early_demux':
>> sysctl_net_ipv4.c:(.text+0x7fe04): undefined reference to 
>> `tcp_v6_early_demux_configure'
   net/built-in.o: In function `proc_udp_early_demux':
>> sysctl_net_ipv4.c:(.text+0x7fe3d): undefined reference to 
>> `udp_v6_early_demux_configure'

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

[David Miller]

From: Subash Abhinov Kasiviswanathan 
Date: Wed, 22 Mar 2017 21:55:04 -0600

>> This doesn't build with ipv6 as a module:
>> net/built-in.o: In function `proc_tcp_early_demux':
>> sysctl_net_ipv4.c:(.text+0x145cfc): undefined reference to
>> `tcp_v6_early_demux_configure'
>> net/built-in.o: In function `proc_udp_early_demux':
>> sysctl_net_ipv4.c:(.text+0x145d4c): undefined reference to
>> `udp_v6_early_demux_configure'
>> Makefile:983: recipe for target 'vmlinux' failed
> 
> Hi David
> 
> Sorry about that (we always have IPV6 enabled).
> Do I have to send a v5 or separate patch for this?

Please send a v5, thanks.

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

[Subash Abhinov Kasiviswanathan]

This doesn't build with ipv6 as a module:

net/built-in.o: In function `proc_tcp_early_demux':
sysctl_net_ipv4.c:(.text+0x145cfc): undefined reference to
`tcp_v6_early_demux_configure'
net/built-in.o: In function `proc_udp_early_demux':
sysctl_net_ipv4.c:(.text+0x145d4c): undefined reference to
`udp_v6_early_demux_configure'
Makefile:983: recipe for target 'vmlinux' failed


Hi David

Sorry about that (we always have IPV6 enabled).
Do I have to send a v5 or separate patch for this?

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,

a Linux Foundation Collaborative Project

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

[David Miller]

From: David Miller 
Date: Wed, 22 Mar 2017 19:43:57 -0700 (PDT)

> From: Subash Abhinov Kasiviswanathan 
> Date: Wed, 22 Mar 2017 20:00:41 -0600
> 
>> Certain system process significant unconnected UDP workload.
>> It would be preferrable to disable UDP early demux for those systems
>> and enable it for TCP only.
>> 
>> By disabling UDP demux, we see these slight gains on an ARM64 system-
>> 782 -> 788Mbps unconnected single stream UDPv4
>> 633 -> 654Mbps unconnected UDPv4 different sources
>> 
>> The performance impact can change based on CPU architecure and cache
>> sizes. There will not much difference seen if entire UDP hash table
>> is in cache.
>> 
>> Both sysctls are enabled by default to preserve existing behavior.
>> 
>> v1->v2: Change function pointer instead of adding conditional as
>> suggested by Stephen.
>> 
>> v2->v3: Read once in callers to avoid issues due to compiler
>> optimizations. Also update commit message with the tests.
>> 
>> v3>v4: Store and use read once result instead of querying pointer
>> again incorrectly.
>> 
>> Signed-off-by: Subash Abhinov Kasiviswanathan 
>> Suggested-by: Eric Dumazet 
> 
> Applied, thanks.

This doesn't build with ipv6 as a module:

net/built-in.o: In function `proc_tcp_early_demux':
sysctl_net_ipv4.c:(.text+0x145cfc): undefined reference to 
`tcp_v6_early_demux_configure'
net/built-in.o: In function `proc_udp_early_demux':
sysctl_net_ipv4.c:(.text+0x145d4c): undefined reference to 
`udp_v6_early_demux_configure'
Makefile:983: recipe for target 'vmlinux' failed

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

[David Miller]

From: Subash Abhinov Kasiviswanathan 
Date: Wed, 22 Mar 2017 20:00:41 -0600

> Certain system process significant unconnected UDP workload.
> It would be preferrable to disable UDP early demux for those systems
> and enable it for TCP only.
> 
> By disabling UDP demux, we see these slight gains on an ARM64 system-
> 782 -> 788Mbps unconnected single stream UDPv4
> 633 -> 654Mbps unconnected UDPv4 different sources
> 
> The performance impact can change based on CPU architecure and cache
> sizes. There will not much difference seen if entire UDP hash table
> is in cache.
> 
> Both sysctls are enabled by default to preserve existing behavior.
> 
> v1->v2: Change function pointer instead of adding conditional as
> suggested by Stephen.
> 
> v2->v3: Read once in callers to avoid issues due to compiler
> optimizations. Also update commit message with the tests.
> 
> v3>v4: Store and use read once result instead of querying pointer
> again incorrectly.
> 
> Signed-off-by: Subash Abhinov Kasiviswanathan 
> Suggested-by: Eric Dumazet 

Applied, thanks.