Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.
From: Jiri Pirko Date: Mon, 30 Jul 2018 18:49:23 +0200 > So the changelog stays in the commit message, right? Yes.
Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.
Mon, Jul 30, 2018 at 06:31:00PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 30 Jul 2018 14:40:13 +0200 > >> Oh, another nitpick: The changelog should go under "---" line. That way, >> the maintainer does not have to deal with it during apply (git apply >> will cut it out). > >I actually like the changelog to be _IN_ the commit message. > >It's useful information that helps someone investigating history >in the tree later. > >Please do not tell people to pull changelogs out of the commit >message, thank you. I've been telling them to do the exact >opposite. Oups. Interesting. So the changelog stays in the commit message, right? I noticed that in the past but thought it was an accident. Sorry about that. I owe you just another beer :)
Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.
From: Jiri Pirko Date: Mon, 30 Jul 2018 14:40:13 +0200 > Oh, another nitpick: The changelog should go under "---" line. That way, > the maintainer does not have to deal with it during apply (git apply > will cut it out). I actually like the changelog to be _IN_ the commit message. It's useful information that helps someone investigating history in the tree later. Please do not tell people to pull changelogs out of the commit message, thank you. I've been telling them to do the exact opposite.
Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.
Mon, Jul 30, 2018 at 02:30:44PM CEST, pab...@redhat.com wrote: >This is similar TC_ACT_REDIRECT, but with a slightly different >semantic: >- on ingress the mirred skbs are passed to the target device >network stack without any additional check not scrubbing. >- the rcu-protected stats provided via the tcf_result struct > are updated on error conditions. > >This new tcfa_action value is not exposed to the user-space >and can be used only internally by clsact. > >v1 -> v2: do not touch TC_ACT_REDIRECT code path, introduce > a new action type instead >v2 -> v3: > - rename the new action value TC_ACT_REINJECT, update the > helper accordingly > - take care of uncloned reinjected packets in XDP generic > hook >v3 -> v4: > - renamed again the new action value (JiriP) >v4 -> v5: > - fix build error with !NET_CLS_ACT (kbuild bot) Oh, another nitpick: The changelog should go under "---" line. That way, the maintainer does not have to deal with it during apply (git apply will cut it out). > >Signed-off-by: Paolo Abeni Acked-by: Jiri Pirko
