Re: [PATCH net 1/1] net sched ife action: fix encoding to use real length
On 16-08-19 09:22 AM, Sergei Shtylyov wrote:
Hello.
On 8/19/2016 1:17 PM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim
Encoding of the metadata was using the padded length as opposed to
the real length of the data which is a bug per specification.
This has not been an issue todate because all metadatum specified
To date? Metadata perhaps?
Todate as in "up to today".
so far has been 32 bit where aligned and data length are the same width.
This also includes a bug fix for validating the length of a u16 field.
But since there is no metadata of size u16 yes we are fine to include it
here.
While at it get rid of magic numbers
Fixes: ef6980b6
This tag has a standardized format, including 12-digit SHA1 and the
commit summary enclosed in ("").
Ok, let me fix that and resend.
cheers,
jamal
Re: [PATCH net 1/1] net sched ife action: fix encoding to use real length
Hello.
On 8/19/2016 1:17 PM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim
Encoding of the metadata was using the padded length as opposed to
the real length of the data which is a bug per specification.
This has not been an issue todate because all metadatum specified
To date? Metadata perhaps?
so far has been 32 bit where aligned and data length are the same width.
This also includes a bug fix for validating the length of a u16 field.
But since there is no metadata of size u16 yes we are fine to include it
here.
While at it get rid of magic numbers
Fixes: ef6980b6
This tag has a standardized format, including 12-digit SHA1 and the commit
summary enclosed in ("").
Signed-off-by: Jamal Hadi Salim
[...]
MBR, Sergei
