Re: [PATCH netdev-2.6 32/39] Added disable packet split capability

2006-01-17 Thread Jeff Garzik 

Jeff Kirsher wrote:

Adds the ability to disability packet split at compile time and use the legacy 
receive path on PCI express hardware.

Signed-off-by: Jeff Kirsher [EMAIL PROTECTED]
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]


NAK, use CONFIG for this sort of stuff


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH netdev-2.6 32/39] Added disable packet split capability

2006-01-13 Thread Jesse Brandeburg 
On 1/12/06, Andi Kleen [EMAIL PROTECTED] wrote:
 On Friday 13 January 2006 01:51, Jeff Kirsher wrote:
  Adds the ability to disability packet split at compile time and use the
  legacy receive path on PCI express hardware.

 Does this patch really do what you described?

  -#ifdef CONFIG_E1000_PACKET_SPLIT
  +#ifndef DISABLE_PACKET_SPLIT
uint32_t pages = 0;
   #endif

Thanks for the comments, yes, the hardware supports a legacy receive
mode, so compiling our driver (in the kernel) with

make SUBDIRS=drivers/net/e1000 CFLAGS+=-DDISABLE_PACKET_SPLIT modules
(or something like that, I didn't check it for correctness)

will result in a driver that doesn't use packet split.  The hardware
has been tested extensively in both modes.

Jesse
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH netdev-2.6 32/39] Added disable packet split capability

2006-01-12 Thread Andi Kleen 
On Friday 13 January 2006 01:51, Jeff Kirsher wrote:
 Adds the ability to disability packet split at compile time and use the
 legacy receive path on PCI express hardware.

Does this patch really do what you described? 

 -#ifdef CONFIG_E1000_PACKET_SPLIT
 +#ifndef DISABLE_PACKET_SPLIT
   uint32_t pages = 0;
  #endif


...
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH netdev-2.6 32/39] Added disable packet split capability

2006-01-12 Thread Jeff Kirsher 
On 1/12/06, Andi Kleen [EMAIL PROTECTED] wrote:
 On Friday 13 January 2006 01:51, Jeff Kirsher wrote:
  Adds the ability to disability packet split at compile time and use the
  legacy receive path on PCI express hardware.

 Does this patch really do what you described?

  -#ifdef CONFIG_E1000_PACKET_SPLIT
  +#ifndef DISABLE_PACKET_SPLIT
uint32_t pages = 0;
   #endif


 ...
 -
 To unsubscribe from this list: send the line unsubscribe netdev in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at  http://vger.kernel.org/majordomo-info.html


Yes, it does.  By setting pages to 0, the packet split registers will
not be used, which is done later in e1000_setup_rctl().

--
Cheers,
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html