Re: [PATCH v2 bpf-next] bpf: test_bpf: add init_net to dev for flow_dissector

2018-09-27 Thread Daniel Borkmann 
On 09/27/2018 06:42 PM, Willem de Bruijn wrote:
> On Thu, Sep 27, 2018 at 12:40 PM Eric Dumazet  wrote:
>> On 09/27/2018 09:34 AM, Song Liu wrote:
>>> Latest changes in __skb_flow_dissect() assume skb->dev has valid nd_net.
>>> However, this is not true for test_bpf. As a result, test_bpf.ko crashes
>>> the system with the following stack trace:
>>>
>>> This patch fixes tes_bpf by using init_net in the dummy dev.
>>>
>>> Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook")
>>> Reported-by: Eric Dumazet 
>>> Cc: Willem de Bruijn 
>>> Cc: Petar Penkov 
>>> Signed-off-by: Song Liu 
>>> ---
>>
>> Reviewed-by: Eric Dumazet 
> 
> Acked-by: Willem de Bruijn 
> 
> Thanks!

Applied to bpf-next, thanks everyone!

Re: [PATCH v2 bpf-next] bpf: test_bpf: add init_net to dev for flow_dissector

2018-09-27 Thread Willem de Bruijn 
On Thu, Sep 27, 2018 at 12:40 PM Eric Dumazet  wrote:
>
>
>
> On 09/27/2018 09:34 AM, Song Liu wrote:
> > Latest changes in __skb_flow_dissect() assume skb->dev has valid nd_net.
> > However, this is not true for test_bpf. As a result, test_bpf.ko crashes
> > the system with the following stack trace:
> >
> > This patch fixes tes_bpf by using init_net in the dummy dev.
> >
> > Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook")
> > Reported-by: Eric Dumazet 
> > Cc: Willem de Bruijn 
> > Cc: Petar Penkov 
> > Signed-off-by: Song Liu 
> > ---
>
> Reviewed-by: Eric Dumazet 

Acked-by: Willem de Bruijn 

Thanks!

Re: [PATCH v2 bpf-next] bpf: test_bpf: add init_net to dev for flow_dissector

2018-09-27 Thread Eric Dumazet 



On 09/27/2018 09:34 AM, Song Liu wrote:
> Latest changes in __skb_flow_dissect() assume skb->dev has valid nd_net.
> However, this is not true for test_bpf. As a result, test_bpf.ko crashes
> the system with the following stack trace:
> 
> This patch fixes tes_bpf by using init_net in the dummy dev.
> 
> Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook")
> Reported-by: Eric Dumazet 
> Cc: Willem de Bruijn 
> Cc: Petar Penkov 
> Signed-off-by: Song Liu 
> ---

Reviewed-by: Eric Dumazet 

Thanks.