Re: ipw2200: Driver lockup
On Wed, 2006-07-19 at 22:58 -0400, John W. Linville wrote:
> For what it is worth, there was a patch for this posted back
> in January. It stirred-up a kerfluffle, so it never got merged.
> FWIW, it touches on 802.11e QoS and multiple TX queues -- my personal
> favorite wireless subject...NOT!
>
> The thread is available here (first post not connected to follow-up
> thread for some reason):
>
> http://marc.theaimsgroup.com/?l=linux-netdev&m=113809246102858&w=2
> http://marc.theaimsgroup.com/?l=linux-netdev&m=113814103024576&w=2
>
> Given that half a year has passed, does anyone have any better ideas
> now? Should I merge the patch? Or is the cure worse than the disease?
The patch from Stefan Rompf in the second link has already been merged.
The first one was already merged (with slightly difference). We can just
remove the ieee80211 warning now.
[PATCH] ieee80211: remove ieee80211_tx() is_queue_full warning
Signed-off-by: Zhu Yi <[EMAIL PROTECTED]>
---
--- a/net/ieee80211/ieee80211_tx.c
+++ b/net/ieee80211/ieee80211_tx.c
@@ -533,13 +533,6 @@ int ieee80211_xmit(struct sk_buff *skb,
return 0;
}
- if (ret == NETDEV_TX_BUSY) {
- printk(KERN_ERR "%s: NETDEV_TX_BUSY returned; "
- "driver should report queue full via "
- "ieee_device->is_queue_full.\n",
- ieee->dev->name);
- }
-
ieee80211_txb_free(txb);
}
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ipw2200: Driver lockup
On Wed, Jul 19, 2006 at 08:49:57PM -0400, Dan Williams wrote: > On Wed, 2006-07-19 at 10:28 -0400, Ralf Baechle wrote: > > I got the driver to die several times under the extreme condition at the > > KS / OLS with dozens to hundreds of other machines in the same room. The > > last kernel message I got from about the time when wireless died was > > > > eth1: NETDEV_TX_BUSY returned; driver should report queue full via > > ieee_device->is_queue_full. > > I actually get this quite a bit too, at least a couple times per day. > Sometimes the device goes down and you have to rmmod ipw2200, other > times it recovers. But quite annoying anyway. > > Anyone know exactly what that message means, and possibly how to fix it? For what it is worth, there was a patch for this posted back in January. It stirred-up a kerfluffle, so it never got merged. FWIW, it touches on 802.11e QoS and multiple TX queues -- my personal favorite wireless subject...NOT! The thread is available here (first post not connected to follow-up thread for some reason): http://marc.theaimsgroup.com/?l=linux-netdev&m=113809246102858&w=2 http://marc.theaimsgroup.com/?l=linux-netdev&m=113814103024576&w=2 Given that half a year has passed, does anyone have any better ideas now? Should I merge the patch? Or is the cure worse than the disease? John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ipw2200: Driver lockup
On Wed, 2006-07-19 at 10:28 -0400, Ralf Baechle wrote: > I got the driver to die several times under the extreme condition at the > KS / OLS with dozens to hundreds of other machines in the same room. The > last kernel message I got from about the time when wireless died was > > eth1: NETDEV_TX_BUSY returned; driver should report queue full via > ieee_device->is_queue_full. I actually get this quite a bit too, at least a couple times per day. Sometimes the device goes down and you have to rmmod ipw2200, other times it recovers. But quite annoying anyway. Anyone know exactly what that message means, and possibly how to fix it? Dan > Ralf > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
ipw2200: Driver lockup
I got the driver to die several times under the extreme condition at the KS / OLS with dozens to hundreds of other machines in the same room. The last kernel message I got from about the time when wireless died was eth1: NETDEV_TX_BUSY returned; driver should report queue full via ieee_device->is_queue_full. Ralf - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
