Re: net-2.6.24 failure with netconsole

[Herbert Xu]

Andrew Morton [EMAIL PROTECTED] wrote:
 
 David, there's basically no reason ever why anyone should add BUG() or
 BUG_ON() to net code.  Please consider rejecting any patches which add new
 ones.  WARN_ON() is *much* better.  It at least gives the user a chance of
 getting some disgnostic info out, of performing additional tests or even of
 using their kernel if they want to test something else.  The only reason to
 choose BUG over WARN is if we're actually concerned about scrogging
 people's data, or serious things like that (ie: filesystems and mm).

Well, for networking if we continue after a serious coding
error it could result in a remote kernel compromise.  So
BUG_ON/BUG is not entirely useless.

I'm not claiming that it's necessarily the case here though :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: net-2.6.24 failure with netconsole

[David Miller]

From: Andrew Morton [EMAIL PROTECTED]
Date: Tue, 21 Aug 2007 22:54:38 -0700

 Has anyone tested all this new napi stuff with netconsole?  It's pretty
 disastrous.  It immediately goes BUG in napi_enable().

Thomas Graf has found and fixed a bug in the netconsole napi
bits a few hours ago, maybe it fixes this problem?

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: net-2.6.24 failure with netconsole

[Thomas Graf]

* Andrew Morton [EMAIL PROTECTED] 2007-08-21 22:54
 Which used to be a BUG.  It later oopsed via a null-pointer deref in
 net_rx_action(), which is a much preferable result.

I fixed this already

Index: net-2.6.24/include/linux/netpoll.h
===
--- net-2.6.24.orig/include/linux/netpoll.h 2007-08-22 01:02:14.0 
+0200
+++ net-2.6.24/include/linux/netpoll.h  2007-08-22 01:02:30.0 +0200
@@ -75,7 +75,7 @@ static inline void *netpoll_poll_lock(st
struct net_device *dev = napi-dev;
 
rcu_read_lock(); /* deal with race on -npinfo */
-   if (dev-npinfo) {
+   if (dev  dev-npinfo) {
spin_lock(napi-poll_lock);
napi-poll_owner = smp_processor_id();
return napi;
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html