Re: iptables-1.8.1: cannot build without libnftnl

2018-10-24 Thread Florian Westphal
Florian Westphal  wrote:
> Lars Wendler  wrote:
> > > In file included from ../iptables/nft.h:5,
> > >  from libxt_limit.c:18:
> > > ../iptables/nft-shared.h:6:10: fatal error: libnftnl/rule.h: No such
> > > file or directory #include 
> > >   ^
> > > compilation terminated.
> > 
> > and indeed, I don't have libnftnl installed on this system.
> 
> Right, we should not fail here.  I will push this patch shortly:
> 
> Subject: extensions: limit: unbreak build without libnftnl

psuhed to iptables.git, thanks for reporting.


Re: iptables-1.8.1: cannot build without libnftnl

2018-10-24 Thread Florian Westphal
Lars Wendler  wrote:
> > In file included from ../iptables/nft.h:5,
> >  from libxt_limit.c:18:
> > ../iptables/nft-shared.h:6:10: fatal error: libnftnl/rule.h: No such
> > file or directory #include 
> >   ^
> > compilation terminated.
> 
> and indeed, I don't have libnftnl installed on this system.

Right, we should not fail here.  I will push this patch shortly:

Subject: extensions: limit: unbreak build without libnftnl

Lars Wendler reported 1.8.1 build failure when trying to build without nft 
backend:

  In file included from ../iptables/nft.h:5, from libxt_limit.c:18: 
libnftnl/rule.h: No such file or directory

Reported-by: Lars Wendler 
Fixes: 02b80972c43 ("ebtables: Merge libebt_limit.c into libxt_limit.c")
Signed-off-by: Florian Westphal 
---
 extensions/libxt_limit.c | 1 -
 iptables/nft-bridge.h| 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/extensions/libxt_limit.c b/extensions/libxt_limit.c
index c7b66295c09d..1b3246575f22 100644
--- a/extensions/libxt_limit.c
+++ b/extensions/libxt_limit.c
@@ -15,7 +15,6 @@
 #include 
 #include 
 #include 
-#include "iptables/nft.h"
 #include "iptables/nft-bridge.h"
 
 #define XT_LIMIT_AVG   "3/hour"
diff --git a/iptables/nft-bridge.h b/iptables/nft-bridge.h
index 9d49ccbef096..de52cd7195bb 100644
--- a/iptables/nft-bridge.h
+++ b/iptables/nft-bridge.h
@@ -68,6 +68,7 @@ int ebt_get_mac_and_mask(const char *from, unsigned char *to, 
unsigned char *mas
 #define EBT_VERDICT_BITS 0x000F
 
 struct nftnl_rule;
+struct iptables_command_state;
 
 static const char *ebt_standard_targets[NUM_STANDARD_TARGETS] = {
"ACCEPT",


iptables-1.8.1: cannot build without libnftnl

2018-10-24 Thread Lars Wendler
Hi,

I am trying to build iptables-1.8.1 with

> ./configure \
> --prefix=/usr \
> --build=x86_64-pc-linux-gnu \
> --host=x86_64-pc-linux-gnu \
> --mandir=/usr/share/man \
> --infodir=/usr/share/info \
> --datadir=/usr/share \
> --sysconfdir=/etc \
> --localstatedir=/var/lib \
> --disable-dependency-tracking \
> --disable-silent-rules \
> --docdir=/usr/share/doc/iptables-1.8.1 \
> --htmldir=/usr/share/doc/iptables-1.8.1/html \
> --libdir=/usr/lib64 \
> --sbindir=/sbin \
> --libexecdir=/lib64 \
> --enable-devel \
> --enable-shared \
> --disable-nftables \
> --disable-bpf-compiler \
> --disable-nfsynproxy \
> --disable-static \
> --enable-ipv6

but that fails with

> In file included from ../iptables/nft.h:5,
>  from libxt_limit.c:18:
> ../iptables/nft-shared.h:6:10: fatal error: libnftnl/rule.h: No such
> file or directory #include 
>   ^
> compilation terminated.

and indeed, I don't have libnftnl installed on this system.

Full build log: https://bugs.gentoo.org/attachment.cgi?id=552684

Kind regards
Lars

P.S.: Please CC me on replies as I am not subscribed to this list.
-- 
Lars Wendler
Gentoo package maintainer
GPG: 21CC CF02 4586 0A07 ED93  9F68 498F E765 960E 9B39


pgpinL9XisNOy.pgp
Description: Digitale Signatur von OpenPGP