On 2016-01-26 at 21:24:56 +0100, Vadim Kochan <vadi...@gmail.com> wrote:
> Add new trafgen proto generation framework which allows to describe
> proto header fields and easy build the proto header by set/get proto
> header fields value.
>
> Meanwhile implemented Ethernet, ARP, IPv4 & UDP proto headers generation,
> with fixed header size. Each proto has its own syntax rules
> to specify header field, but really looks similary:
>
> { <proto>(<field_1>=<value>,<flag>, <field_2>=<value>) }
>
> Proto statement might be combined with other packet funcs like:
>
> { ip4(mf, proto=0x1), fill(0xff, 100) }
>
> Each proto generates some default header so it is not possible to fill packet
> only with some set of header fields and rest - via fill(..) func.
I applied patches 1-11 from this series now. There were still a few
edges which I want to have a deeper look at, but any changes there can
be done in follow-up patches by myself.
As for patches 12-16: I didn't apply them because I'd like to see the
commit messages for the parser syntax parts (patches a bit extended. I didn't
do
this myself due to lack of time...
Please have a look at the amended commit messages for patches 8 and 11
I edited them quite heavily to include documentation for all supported
keywords, including default values. Please resend the patches for IPv4
and UDP syntax with similar commit messages.
For commit messages in general - and also for user visible messages and
documentation - please don't use abbreviations such as 'func' or 'proto'
but always spell out the full word. This makes it much easier to read
IMO.
As for the manpage part, I'll respond with detailed review comments
there, but in general it looks very good.
Thanks a lot!
--
You received this message because you are subscribed to the Google Groups
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
