Review: Codethink sponsored work on NetSurf, LibCSS and LibDOM
==
Over the last couple of weeks I have been lucky enough to be able
to do work on the NetSurf project at work.
At [Codethink](http://www.codethink.co.uk/) we have an arrangement
that allows engineers to fill time between projects by making
contributions to certain open source projects.
My request to work on [NetSurf](http://www.netsurf-browser.org/),
and more particularly, its [LibDOM](http://ns-b.org/projects/libdom/)
and [LibCSS](http://ns-b.org/projects/libcss/) sub-projects was
approved and I was able to get a good amount done.
LibDOM
--
Most of my time has been spent improving LibDOM; the Document Object
Model library. Since the recent moves towards adding JavaScript
support in NetSurf, various parts of LibDOM that had never been used
are beginning to get exercised. This has revealed various issues.
The first series of changes affected the specialisations of HTMLElement:
* Added a new, more efficient means of identifying an HTML element's
tag name.
* Fixed some missing HTML element specialisations.
* Made some optimisations relating to how the appropriate specialisation
for an element is determined.
* Made the internal workings of HTMLElement specialisation more consistent.
* Exposed a function to enabled client applications to use the new
efficient means of identifying HTML element tag types.
6d60021 Split out tag names from general string table and enum.
57 files changed, 502 insertions(+), 324 deletions(-)
3894e33 Split detection of HTML TAG type out into helper.
1 file changed, 325 insertions(+), 138 deletions(-)
1f07c35 Enable table row HTML element specialisation.
1 file changed, 4 insertions(+)
dd2e075 Add missing specialisation of BLOCKQUOTE.
1 file changed, 4 insertions(+)
8d09ec0 Add missing detection of HTMLDivElement specialisation.
1 file changed, 8 insertions(+)
81c012f Add missing detection of HTMLMetaElement specialisation.
1 file changed, 7 insertions(+)
e346fef Fix up HTMLBaseElement specialisation.
2 files changed, 8 insertions(+), 12 deletions(-)
13df5af Add missing detection of HTMLBaseElement specialisation.
1 file changed, 8 insertions(+)
0174d8b Remove default from HTML element specialisation switch.
1 file changed, 1 deletion(-)
12385d1 Optimise element specialisation: use non-caseless
comparison in ladder.
1 file changed, 63 insertions(+), 63 deletions(-)
13f0636 Optimise HTMLElement specialisation slightly.
1 file changed, 222 insertions(+), 189 deletions(-)
5b6c191 Fix longstanding failure to handle HTMLDirectoryElement
specialisation.
3 files changed, 6 insertions(+), 9 deletions(-)
9def0a4 Merge branch 'tlsa/html-element-type'
4bd00fd Fix: Pass tag_name through to HTMLQuoteElement initialiser.
3 files changed, 9 insertions(+), 8 deletions(-)
809a7dc Merge branch 'tlsa/html-element-type'
bab3f35 Simplified consistant interface to HTMLElement creation.
107 files changed, 894 insertions(+), 972 deletions(-)
5007c80 Store HTMLElement tag types as enum on the html elements.
6 files changed, 15 insertions(+), 7 deletions(-)
fa21110 Style: Fix indentation and tidy up.
1 file changed, 78 insertions(+), 66 deletions(-)
cedfbbc Add function to get html element's tag type.
4 files changed, 41 insertions(+), 1 deletion(-)
e137aa0 Merge branch 'tlsa/html-element-type'
Various profiling sessions indicated that the lower-casing of HTML
attributes was taking too long, so that was optimised.
a37713d Optimise dom_string_(toupper|tolower) functions.
1 file changed, 9 insertions(+), 31 deletions(-)
Another area we were spending too much time was in event dispatch.
Previously we would gather a list of nodes from the event target node
all the way back to the root node. Now we generate a list containing
nodes with registered listeners. In most cases, when there is no
scripting involved we can now avoid generating the list at all.
b4a245f Don't add target event to list of capture/bubbling event
targets.
1 file changed, 2 insertions(+), 4 deletions(-)
7e9681b Remove parameter documentation for non-existant parameter.
1 file changed, 1 deletion(-)
2196dd1 Optimise event dispatch.
1 file changed, 57 insertions(+), 20 deletions(-)
737cb99 Further optimise event dispatch.
1 file changed, 20 insertions(+), 5 deletions(-)
More changes to HTMLElement handling, mostly to extend the list of
known tags to include those that are not specialised in the DOM spec.
acedecb Sort HTML elements to make it easier to see what's there.
1 file changed, 44 insertions(+), 44 deletions(-)
c12b1ea Add full list of HTML5 elements to enum.
2 files changed, 363 insertions(+), 202 deletions(-)
d9c4dec Merge bra
