Re: Deterministic (EC)DSA

2024-05-15 Thread Daiki Ueno
Niels Möller  writes:

> Daiki Ueno  writes:
>
>> I agree, that's a valid use-case.  Perhaps this might suffice:
>>
>>   /* Sign DIGEST with KEY using deterministic nonce generation.
>>*
>>* DIGEST must be of the same length of SHA-256 output, that is 32
>>* octets long. */
>>   void
>>   ecdsa_sha256_sign_deterministic (const struct ecc_scalar *key,
>>const uint8_t *digest,
>>struct dsa_signature *signature);
>
> Looks good to me. Underlying more general helper functions
> (however they are organized) can be internal only.

I've updated the MR along these lines.

Regards,
-- 
Daiki Ueno
___
nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se
To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se


Re: Deterministic (EC)DSA

2024-05-15 Thread Niels Möller
Daiki Ueno  writes:

> I agree, that's a valid use-case.  Perhaps this might suffice:
>
>   /* Sign DIGEST with KEY using deterministic nonce generation.
>*
>* DIGEST must be of the same length of SHA-256 output, that is 32
>* octets long. */
>   void
>   ecdsa_sha256_sign_deterministic (const struct ecc_scalar *key,
>const uint8_t *digest,
>struct dsa_signature *signature);

Looks good to me. Underlying more general helper functions
(however they are organized) can be internal only.

Regards,
/Niels

-- 
Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677.
Internet email is subject to wholesale government surveillance.
___
nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se
To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se