Re: [PATCH]: Endian problem in libnm-util
On Fri, 2006-08-04 at 17:29 +0200, Christan Chiesa wrote: Hello, i friend of mine told me that WPA+plain text pw doesn't work on ppc. After some debug he has found that sha1.c (libnm-utils) isn't built with the -DWORDS_BIGENDIAN flag. I cannot reproduce this bug because i don't have a ppc machine but i wrote a simple patch that could solve this bug. Thank you. No, thank you :) Committed to HEAD and STABLE. Dan ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
[PATCH]: Endian problem in libnm-util
Hello, i friend of mine told me that WPA+plain text pw doesn't work on ppc. After some debug he has found that sha1.c (libnm-utils) isn't built with the -DWORDS_BIGENDIAN flag. I cannot reproduce this bug because i don't have a ppc machine but i wrote a simple patch that could solve this bug. Thank you. christian --- configure.in 2006-07-13 16:01:15.0 +0200 +++ configure.in.new 2006-08-04 14:30:57.0 +0200 @@ -320,6 +320,10 @@ AC_MSG_RESULT(no) fi +if $target_cpu = powerpc + CPU_CFLAGS=-DWORDS_BIGENDIAN $CPU_CFLAGS +fi + AC_OUTPUT([ Makefile include/Makefile ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH]: Endian problem in libnm-util
On Fri, 2006-08-04 at 17:29 +0200, Christan Chiesa wrote: Hello, i friend of mine told me that WPA+plain text pw doesn't work on ppc. After some debug he has found that sha1.c (libnm-utils) isn't built with the -DWORDS_BIGENDIAN flag. I cannot reproduce this bug because i don't have a ppc machine but i wrote a simple patch that could solve this bug. Thanks for finding this; though I think rather than using compile-time flags we should be doing runtime endianness conversions... Dan ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH]: Endian problem in libnm-util
On Fri, 2006-08-04 at 13:59 -0400, Dan Williams wrote: Thanks for finding this; though I think rather than using compile-time flags we should be doing runtime endianness conversions... No architecture we care about (that I know of) has machine types with varying endianness. Robert Love ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
