Re: [PATCH] wifi: allow autoconnect on AP/AdHoc mode connections with manual IP configuration
On Thu, 2016-02-11 at 14:39 -0600, Dan Williams wrote: > On Thu, 2016-02-11 at 13:21 +0100, Thomas Haller wrote: > > > > Patch lgtm, but it doesn't apply anywhere. > > Sorry, patch was against 1.0. I actually tried it on 1.0. But somehow I messed up, because now the patch cleanly applies there... Thomas signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] wifi: allow autoconnect on AP/AdHoc mode connections with manual IP configuration
On Mon, 2016-02-08 at 17:03 -0600, Dan Williams wrote: > The existing checks assumed that all AP/AdHoc connections would use > the > shared IP method. But what we really want to check for here is > whether the > connection is AP/AdHoc. Leave the existing 'shared' check for > backwards > compatibility. > > Also move the check above the timestamp check, since the user > shouldn't need > to manually set a timestamp just to get an AP-mode connection to > autoconnect. > --- > src/devices/wifi/nm-device-wifi.c | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-) > Patch lgtm, but it doesn't apply anywhere. Thomas signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] wifi: allow autoconnect on AP/AdHoc mode connections with manual IP configuration
On Thu, 2016-02-11 at 13:21 +0100, Thomas Haller wrote: > On Mon, 2016-02-08 at 17:03 -0600, Dan Williams wrote: > > The existing checks assumed that all AP/AdHoc connections would use > > the > > shared IP method. But what we really want to check for here is > > whether the > > connection is AP/AdHoc. Leave the existing 'shared' check for > > backwards > > compatibility. > > > > Also move the check above the timestamp check, since the user > > shouldn't need > > to manually set a timestamp just to get an AP-mode connection to > > autoconnect. > > --- > > src/devices/wifi/nm-device-wifi.c | 19 +-- > > 1 file changed, 13 insertions(+), 6 deletions(-) > > > > > Patch lgtm, but it doesn't apply anywhere. Sorry, patch was against 1.0. I've fixed it up for master and pushed to 1.0 and master. Dan ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list